Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Writes hooks.js to wrong filesystem #43

Open
bredmor opened this issue Jun 22, 2019 · 0 comments
Open

[BUG] Writes hooks.js to wrong filesystem #43

bredmor opened this issue Jun 22, 2019 · 0 comments

Comments

@bredmor
Copy link

bredmor commented Jun 22, 2019

  • Hooks Version: 1.0.8
  • Laravel Version: 5.8.24
  • PHP Version: 7.3
  • Integration: voyager-hooks

Description:

The package attempts to write and load from base_path('hooks/hooks.json'), regardless of available disks in config/filesystems.php. This breaks on frozen filesystems such as AWS Lambda and Google App Engine.

Steps To Reproduce:

Attempt to use the package without write permissions to the local FS. Changing disk configurations in laravel settings is not respected and has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant