-
Notifications
You must be signed in to change notification settings - Fork 39.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix disruptive subPath test failures
This PR fixes two distruptive subpath test failures. 1. disable --check-volume-lifecycle check 2. skip hostpath driver tests on graceful pod deletion test too. See details in #103651 (comment) Change-Id: Ibecd051be865feea5f2a92d22ade848367400939
- Loading branch information
Showing
2 changed files
with
8 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -235,9 +235,9 @@ func (h *hostpathCSIDriver) PrepareTest(f *framework.Framework) (*storageframewo | |
// testsuites/volumelimits.go `should support volume limits` | ||
// test. | ||
"--maxvolumespernode=10", | ||
// Enable volume lifecycle checks, to report failure if | ||
// the volume is not unpublished / unstaged correctly. | ||
"--check-volume-lifecycle=true", | ||
// Disable volume lifecycle checks due to issue #103651 | ||
// TODO: enable this check once issue is resolved for csi-host-path driver. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
pohly
Contributor
|
||
"--check-volume-lifecycle=false", | ||
}, | ||
ProvisionerContainerName: "csi-provisioner", | ||
SnapshotterContainerName: "csi-snapshotter", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jingxu97 : is there an open issue for this TODO?
Such TODOs tend to get forgotten without an issue.