Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.1
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.2
Choose a head ref
  • 9 commits
  • 8 files changed
  • 7 contributors

Commits on May 19, 2022

  1. bug: don't override global log in builder

    The recent change
    598978c#diff-e77b9468ab935d5ea4d5cdae3b994114bada17df0001570e4b1436419afd50ccR312
    introduced a bug by overriding `log` with the log created by a builder,
    resulting in all logs produced by `controller-runtime` having
    `controller`, `controllerGroup` and `controllerKind` set to the last
    created controller.
    adracus authored and k8s-infra-cherrypick-robot committed May 19, 2022
    Configuration menu
    Copy the full SHA
    19f8d99 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1911 from k8s-infra-cherrypick-robot/cherry-pick-…

    …1907-to-release-0.12
    
    🐛 don't override global log in builder
    k8s-ci-robot committed May 19, 2022
    Configuration menu
    Copy the full SHA
    1efdbd7 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Fix issue with starting multiple test envs

    When starting a single test environment [1], the control plane start-up
    logic [2] launches an etcd and kube-apiserver process. The start-up
    logic needs to bind these processes to multiple ports, and when none are
    configured in advance, the logic looks for unused ports, and then
    creates files in the user cache directory to reserve them (for example,
    [3]).
    
    However, the same logic used to reserve ports  also has logic that
    deletes files corresponding to "outdated" ports [4].
    
    Therefore, if there are multiple processes/threads starting a test
    environment, they may sometimes end up trying to delete the same file
    which causes a "file not found" error.
    
    This commit adds logic so that trying to start multiple test
    environments does not fail if more than one tries to delete the same
    file corresponding to an outdated port.
    
    [1] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/envtest/server.go#L197
    [2] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/controlplane/plane.go#L49
    [3] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/controlplane/etcd.go#L120
    [4] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/addr/manager.go#L64
    jcanseco authored and k8s-infra-cherrypick-robot committed May 24, 2022
    Configuration menu
    Copy the full SHA
    6c84577 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1913 from k8s-infra-cherrypick-robot/cherry-pick-…

    …1910-to-release-0.12
    
    🐛 Fix issue with starting multiple test envs
    k8s-ci-robot committed May 24, 2022
    Configuration menu
    Copy the full SHA
    160efcb View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Allow TLS config to be entirely configured on webhook server

    Some operators might want to respect cluster-wide TLS ciphers for example,
    which means that these will eventually have to be passed down to the webhook server.
    
    Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
    akalenyu authored and k8s-infra-cherrypick-robot committed May 25, 2022
    Configuration menu
    Copy the full SHA
    54d6a15 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1914 from k8s-infra-cherrypick-robot/cherry-pick-…

    …1897-to-release-0.12
    
    ✨ Allow TLS to be entirely configured on webhook server
    k8s-ci-robot committed May 25, 2022
    Configuration menu
    Copy the full SHA
    d15de97 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Fix webhook write response error for broken HTTP connection

    Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
    FillZpp authored and k8s-infra-cherrypick-robot committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0d4500b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1931 from k8s-infra-cherrypick-robot/cherry-pick-…

    …1930-to-release-0.12
    
    🐛 Fix webhook write response error for broken HTTP connection
    k8s-ci-robot committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    697e66d View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. ✨ Bump k8s.io packages to v1.24.2 (#1940)

    * Bump k8s.io packages to v1.24.2
    
    * go mod tidy
    
    Co-authored-by: Friedrich Wilken <jens.wilken@sap.com>
    Configuration menu
    Copy the full SHA
    f561596 View commit details
    Browse the repository at this point in the history
Loading