-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Comparing changes
Open a pull request
base repository: kubernetes-sigs/controller-runtime
base: v0.12.1
head repository: kubernetes-sigs/controller-runtime
compare: v0.12.2
- 9 commits
- 8 files changed
- 7 contributors
Commits on May 19, 2022
-
bug: don't override global log in builder
The recent change 598978c#diff-e77b9468ab935d5ea4d5cdae3b994114bada17df0001570e4b1436419afd50ccR312 introduced a bug by overriding `log` with the log created by a builder, resulting in all logs produced by `controller-runtime` having `controller`, `controllerGroup` and `controllerKind` set to the last created controller.
Configuration menu - View commit details
-
Copy full SHA for 19f8d99 - Browse repository at this point
Copy the full SHA 19f8d99View commit details -
Merge pull request #1911 from k8s-infra-cherrypick-robot/cherry-pick-…
…1907-to-release-0.12 🐛 don't override global log in builder
Configuration menu - View commit details
-
Copy full SHA for 1efdbd7 - Browse repository at this point
Copy the full SHA 1efdbd7View commit details
Commits on May 24, 2022
-
Fix issue with starting multiple test envs
When starting a single test environment [1], the control plane start-up logic [2] launches an etcd and kube-apiserver process. The start-up logic needs to bind these processes to multiple ports, and when none are configured in advance, the logic looks for unused ports, and then creates files in the user cache directory to reserve them (for example, [3]). However, the same logic used to reserve ports also has logic that deletes files corresponding to "outdated" ports [4]. Therefore, if there are multiple processes/threads starting a test environment, they may sometimes end up trying to delete the same file which causes a "file not found" error. This commit adds logic so that trying to start multiple test environments does not fail if more than one tries to delete the same file corresponding to an outdated port. [1] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/envtest/server.go#L197 [2] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/controlplane/plane.go#L49 [3] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/controlplane/etcd.go#L120 [4] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/addr/manager.go#L64
Configuration menu - View commit details
-
Copy full SHA for 6c84577 - Browse repository at this point
Copy the full SHA 6c84577View commit details -
Merge pull request #1913 from k8s-infra-cherrypick-robot/cherry-pick-…
…1910-to-release-0.12 🐛 Fix issue with starting multiple test envs
Configuration menu - View commit details
-
Copy full SHA for 160efcb - Browse repository at this point
Copy the full SHA 160efcbView commit details
Commits on May 25, 2022
-
Allow TLS config to be entirely configured on webhook server
Some operators might want to respect cluster-wide TLS ciphers for example, which means that these will eventually have to be passed down to the webhook server. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 54d6a15 - Browse repository at this point
Copy the full SHA 54d6a15View commit details -
Merge pull request #1914 from k8s-infra-cherrypick-robot/cherry-pick-…
…1897-to-release-0.12 ✨ Allow TLS to be entirely configured on webhook server
Configuration menu - View commit details
-
Copy full SHA for d15de97 - Browse repository at this point
Copy the full SHA d15de97View commit details
Commits on Jun 14, 2022
-
Fix webhook write response error for broken HTTP connection
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0d4500b - Browse repository at this point
Copy the full SHA 0d4500bView commit details -
Merge pull request #1931 from k8s-infra-cherrypick-robot/cherry-pick-…
…1930-to-release-0.12 🐛 Fix webhook write response error for broken HTTP connection
Configuration menu - View commit details
-
Copy full SHA for 697e66d - Browse repository at this point
Copy the full SHA 697e66dView commit details
Commits on Jun 23, 2022
-
✨ Bump k8s.io packages to v1.24.2 (#1940)
* Bump k8s.io packages to v1.24.2 * go mod tidy Co-authored-by: Friedrich Wilken <jens.wilken@sap.com>
Configuration menu - View commit details
-
Copy full SHA for f561596 - Browse repository at this point
Copy the full SHA f561596View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.12.1...v0.12.2