Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] no indication when I mistype a space #90

Closed
rhuygen opened this issue Jul 27, 2024 · 4 comments
Closed

[BUG] no indication when I mistype a space #90

rhuygen opened this issue Jul 27, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@rhuygen
Copy link

rhuygen commented Jul 27, 2024

Describe the bug 🐛

When I should type a space but by mistake type another character, I see no error, and a space is printed anyway. I think this should be considered as an error and maybe a red underscore should be printed to indicate the error.

To Reproduce 🐣

  1. Start a test by typing the letters
  2. type another character when a space should be typed

Expected behavior 🤔

I would expect an indication that a wrong character was typed. Perhaps an red underscore could be used for this.

Screenshots 🧐

No response

Your operating system name

macOS

Your operating system version

Sonoma 14.5

Additional context 📝

I'm using iTerm2.

@rhuygen rhuygen added the bug Something isn't working label Jul 27, 2024
@kraanzu
Copy link
Owner

kraanzu commented Jul 27, 2024

Hi @rhuygen !

True, this will indeed confuse the user if they see all green letters but accuracy is not 100%

I'm trying to think about the possibilities here, i.e. the character to use

image

image

I have these two options here. Personally, I liked the former. What do you think?

@rhuygen
Copy link
Author

rhuygen commented Jul 27, 2024

Hi, I’m happy with both of them, if users have different preferences, you could make it a config item.

@kraanzu
Copy link
Owner

kraanzu commented Jul 27, 2024

Hmmm... I don't want to populate the settings with unnecessary ones
I guess I'll merge this and add a setting in the future if someone wants it

Copy link

Did we solve your problem?

Glad we could help!
Don't forget to star the repository!
@kraanzu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants