Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow block_network.allowed_hosts configuration via fixture #82

Conversation

AndreCimander
Copy link
Contributor

@AndreCimander AndreCimander commented May 1, 2022

Description

Extended pytest_recording.plugin.block_network to allow configuration of allowed_hosts via vcr_config fixture.

I had to version pin werkzeug<2.1.0 to avoid postmanlabs/httpbin#673, not sure if you would like to move this change to a separate PR :)

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Added a changelog entry
  • Extended the README / documentation, if necessary

@AndreCimander AndreCimander changed the title Feature: Allow block_network.allowed_hosts config via fixture Feature: Allow block_network.allowed_hosts configuration via fixture May 1, 2022
docs/changelog.rst Outdated Show resolved Hide resolved
@Stranger6667
Copy link
Collaborator

Yep, looks good to me! A small syntactic issue in the changelog

Re: Werkzeug - I am ok with having this change here :)

@Stranger6667
Copy link
Collaborator

Thanks for bringing this change! :)

@AndreCimander
Copy link
Contributor Author

Updated the changelog.

((Pycharm`s local history tried to revert your change suggestion 👀 ))

@Stranger6667
Copy link
Collaborator

Seems like another tox job requires pinning werkzeug

@AndreCimander
Copy link
Contributor Author

Updated deps for failing tox job, also updated black version in pre-commit-config.yaml to 22.3.0 in order to handle click compatibility.

psf/black#2976

@AndreCimander
Copy link
Contributor Author

Sorry, was a busy week and time flies...

Updated PR, one test needed a pluggypatch update and there was a lingering black formatting issue in pytest_recording.network that I also included to satisfy the pre-commit hooks.

@Stranger6667
Copy link
Collaborator

Thanks! I'll take a look at codecov integration tomorrow

@Stranger6667 Stranger6667 force-pushed the feature_block_network_config_via_fixture branch from 8dbbb03 to 09904bc Compare June 16, 2022 10:18
@Stranger6667 Stranger6667 force-pushed the feature_block_network_config_via_fixture branch from 09904bc to 200d585 Compare June 16, 2022 10:22
@Stranger6667
Copy link
Collaborator

Thank you @AndreCimander and sorry for the delay!

@Stranger6667 Stranger6667 merged commit 906e597 into kiwicom:master Jun 20, 2022
@AndreCimander
Copy link
Contributor Author

@Stranger6667 no worries there, time is flying, thanks for the review and the merge!

Wanted to rewrite the commit messages to satisfy conventional commits, but did not find the time to do it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants