Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #2

Merged
merged 17 commits into from
Aug 9, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated pods
  • Loading branch information
ArtSabintsev committed Jun 2, 2022
commit 0325de208a171f7b65854329aa6399f9053306c5
2 changes: 1 addition & 1 deletion Example/Podfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :ios, '11.0'
platform :ios, '15.0'
inhibit_all_warnings!
use_frameworks!

Expand Down
8 changes: 4 additions & 4 deletions Example/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PODS:
- Siren (6.0.0)
- Siren (6.0.2)

DEPENDENCIES:
- Siren (from `../`)
Expand All @@ -9,8 +9,8 @@ EXTERNAL SOURCES:
:path: "../"

SPEC CHECKSUMS:
Siren: 1f58945ba6e86a753eeaeddf0afa531cf05cdabf
Siren: 1be92ef5775f9b61ebb294c79c59268ab0afcf5d

PODFILE CHECKSUM: d209d935a01eba61b70c991ab419cca0ce2264cc
PODFILE CHECKSUM: 5800641824958ea506d6ae52e89b594fe8270c18

COCOAPODS: 1.10.2
COCOAPODS: 1.11.2
4 changes: 2 additions & 2 deletions Example/Pods/Local Podspecs/Siren.podspec.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Example/Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

370 changes: 185 additions & 185 deletions Example/Pods/Pods.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Example/Pods/Target Support Files/Siren/Siren-Info.plist

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions Sources/Siren.swift
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,21 @@ public final class Siren: NSObject {
/// The last date that an alert was presented to the user.
private var alertPresentationDate: Date? = UserDefaults.alertPresentationDate

/**
Prevents the update dialog from not displaying when the user swipes down
on a notification center notification to the bottom of screen when calling
the Siren.shared.wail notificaiton using the `.onForeground` performCheck option.
**/
private var appDidBecomeActiveWorkItem: DispatchWorkItem?


/// The App Store's unique identifier for an app.
private var appID: Int?

/// The completion handler used to return the results or errors returned by Siren.
private var resultsHandler: ResultsHandler?

/// Prevent can't appear update dialog when user swipe down the notification center screen to the bottom of screen when called Siren.shared.wail as .onForeground
private var appDidBecomeActiveWorkItem: DispatchWorkItem?


/// The time to consider what is it called by notification center screen to bottom
private let delayTimeToConsiderCalledByNotificationCenterScreen = 0.02

Expand Down Expand Up @@ -289,7 +295,7 @@ private extension Siren {
queue: nil) { [weak self] _ in
guard let self = self else { return }
self.appDidBecomeActiveWorkItem = DispatchWorkItem {
self.performVersionCheck()
await self.performVersionCheck()
}
if let appDidBecomeActiveWorkItem = self.appDidBecomeActiveWorkItem {
DispatchQueue.main.asyncAfter(deadline: .now() + self.delayTimeToConsiderCalledByNotificationCenterScreen, execute: appDidBecomeActiveWorkItem)
Expand Down