Merge upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kientux <kiennt@sapo.vn>
* Update dialog can't appear bug Problem 1. Check update as .onForeground (Siren.shared.wail(performCheck: .onForeground)) 2. If user swipe down the notification center screen to the bottom of screen (by swiping downward from the very top of the device's screen) 3. And back to app can't appear update dialog Reason If swipe down the notification center screen to the bottom of screen iOS call observer like this 1. starting to swipe down : willResignActiveNotification 2. reached to bottom : didBecomeActiveNotification, willResignActiveNotification * Update Siren.swift * Null safety and don't hardcode The delay time what to consider is it called by notification center screen to bottom become constant And appDidBecomeActiveWorkItem is used null safety Co-authored-by: seokmin <jsm@dio.co.kr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.