Handle error codes in derived measurement functions #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `getRawTemperature` and `getRawPressure()` return 0 on failure, the corresponding high-level functions should return `NaN`, rather than processing 0 and emitting a meaningless value.
eric-wieser
added a commit
to cuspaceflight/kestrel
that referenced
this pull request
Nov 25, 2013
This has been submitted upstream to jrowberg/i2cdevlib#52
eric-wieser
added a commit
to cuspaceflight/kestrel
that referenced
this pull request
Nov 30, 2013
This has been submitted upstream to jrowberg/i2cdevlib#52
|
A little old, but this should still be good to merge, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
getRawTemperatureandgetRawPressure()return 0 on failure, the corresponding high-level functions should returnNaN, rather than processing 0 and emitting a meaningless value.