Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fse.copy throws error when only src and dest provided #215

Merged
merged 1 commit into from
Jan 27, 2016

Conversation

ioncreature
Copy link
Contributor

I have a lot of legacy code which uses old version(0.12.0) of fs-extra.
Old code does not work with new fs-extra due to it uses fse.copy with only 2 arguments src and dest.
Let's improve backward compatibility, guys

I have a lot of legacy code which uses old version(0.12.0) of fs-extra.
Old code does not work with new fs-extra due to it uses fse.copy with only 2 arguments `src` and `dest`.
Let's improve backward compatibility, guys
jprichardson added a commit that referenced this pull request Jan 27, 2016
fse.copy throws error when only src and dest provided
@jprichardson jprichardson merged commit 02ca57c into jprichardson:master Jan 27, 2016
@jprichardson
Copy link
Owner

Thank you, this is a documentation failure on my part as fse.copy() should have never have been used with two arguments OR I should have anticipate that people would have used it in such a way and added a test to ensure that it doesn't fail.

@jprichardson
Copy link
Owner

Published as 0.26.5.

@ioncreature
Copy link
Contributor Author

@jprichardson Thanks for quick response!
Could you update it on npm?

It would be nice to use this patch right now.

Thanks again.

@ioncreature
Copy link
Contributor Author

Wow, you are reading my thoughts )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants