Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress ensureLink & ensureSymlink dest exists error #169

Merged
merged 1 commit into from
Aug 7, 2015

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Aug 6, 2015

Here's the dest error suppressing for ensureLink thoughts? I'd do the same for ensureSymlink

suppress ensuresync dest exists error
@reggi
Copy link
Contributor Author

reggi commented Aug 6, 2015

Added symlink in here too, and rebased to one commit.

@reggi reggi changed the title suppress ensurelink dest exists error suppress ensureLink & ensureSymlink dest exists error Aug 6, 2015
@reggi reggi mentioned this pull request Aug 6, 2015
jprichardson added a commit that referenced this pull request Aug 7, 2015
suppress ensureLink & ensureSymlink dest exists error
@jprichardson jprichardson merged commit 9a28bac into jprichardson:master Aug 7, 2015
@jprichardson
Copy link
Owner

Thanks!

@jprichardson
Copy link
Owner

Hmm... what if the link exists but it's to another source?

@reggi
Copy link
Contributor Author

reggi commented Aug 7, 2015

@jprichardson This doesn't check the type of the file, or if the content is the right content. The way I understood ensure is, "ensure it's on the system" if it exist's in any way shape or form it's ensured, no? This could check if it's ensured as a specific type of path (using stat) and if the content is what it should be. But then what? Throw an error? I'm pretty comfortable with this as it is. I do want to see the extensible range of ensure derivative functions that I talk about here I'd chalk all this functionality into a ensureMatch derivative.

tl;dr I'm ok with if it's to another source, it's ensured to exist

@jprichardson
Copy link
Owner

Fair points. We'll leave it as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants