Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip copy & copySync timestamp tests on 32-bit computers #450

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Jun 27, 2017

This should get appveyor passing

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.925% when pulling 5f888ba on windows-tests into 15db64f on master.

Copy link
Owner

@jprichardson jprichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but for full transparency, IIRC, the arch property doesn't actually tell if the CPU processor is 32 or 64, but only if Node was compiled with 32-bit / 64-bit. I.e. you could have 32-bit Node.js running on a 64-bit operating system. I'm not sure the practical implications of this are, I just wanted to document for posterity.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Jun 27, 2017

Looks good, but for full transparency, IIRC, the arch property doesn't actually tell if the CPU processor is 32 or 64, but only if Node was compiled with 32-bit / 64-bit. I.e. you could have 32-bit Node.js running on a 64-bit operating system.

Now that you say this, I do remember talking about this when we added a warning for using the preserveTimestamps option. IIRC, if Node is compiled for 32-bit, timestamps still aren't accurate. Anyhow, doesn't really matter since this is just tests.

@RyanZim RyanZim merged commit 85f531e into master Jun 27, 2017
@RyanZim RyanZim deleted the windows-tests branch June 27, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants