Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename clobber flags to overwrite #172

Closed
jprichardson opened this issue Aug 11, 2015 · 8 comments
Closed

rename clobber flags to overwrite #172

jprichardson opened this issue Aug 11, 2015 · 8 comments
Assignees
@RyanZim
Milestone
2.0.0

Comments

@jprichardson
Copy link
Owner

No description provided.

@jprichardson jprichardson added this to the 1.0 milestone Aug 11, 2015
@RyanZim
Copy link
Collaborator

RyanZim commented Oct 27, 2016

@jprichardson Is this still in the sights for v1.0.0?

@jprichardson jprichardson modified the milestones: 2.0.0, 1.0.0 Oct 27, 2016
@jprichardson
Copy link
Owner Author

overwrite seems more intuitive as a name. But we can push this off to 2.0.

@RyanZim RyanZim mentioned this issue Nov 19, 2016
Closed
@RyanZim RyanZim self-assigned this Dec 24, 2016
RyanZim added a commit that referenced this issue Dec 24, 2016
@RyanZim
Rename clobber to overwrite
4f753e4 
Keep clobber for backwards compatibility

Fixes #172
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 24, 2016

I have this done on a branch, will rebase & open a PR when #330 is merged.

@jprichardson
Copy link
Owner Author

Thanks! Does clobber still work? If not, do you think we should? If so, do you think we should show a deprecation message?

@RyanZim
Copy link
Collaborator

RyanZim commented Dec 26, 2016

@jprichardson Currently clobber works without a deprecation message. Personally, I wouldn't add a deprecation message yet. Maybe later?

@jprichardson
Copy link
Owner Author

Currently clobber works without a deprecation message.

"Currently' as defined by after 2.0 released with clobber renamed to overwrite? I'm just trying to limit people's code breaking prematurely if we don't have to.

@RyanZim
Copy link
Collaborator

RyanZim commented Dec 28, 2016

"Currently' as defined by after 2.0 released with clobber renamed to overwrite?

Correct! 💯 I should have said "as Currently implemented in my branch".

RyanZim added a commit that referenced this issue Dec 29, 2016
@RyanZim
Rename clobber to overwrite
5be5ae3 
Keep clobber for backwards compatibility

Fixes #172
@RyanZim RyanZim mentioned this issue Dec 29, 2016
Merged
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 31, 2016

Fixed by #333, will be released in v2.

@RyanZim RyanZim closed this as completed Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanZim RyanZim

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@jprichardson @RyanZim