Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaration of ActiveRecord\DateTime::setTime($hour, $minute, $second = 0) should be compatible with DateTime::setTime #571

Open
des1roer opened this issue May 6, 2017 · 1 comment

Comments

@des1roer
Copy link

des1roer commented May 6, 2017

Warning: Declaration of ActiveRecord\DateTime::setTime($hour, $minute, $second = 0) should be compatible with DateTime::setTime($hour, $minute, $second = NULL, $microseconds = NULL) in F:\OpenServer\domains\localhost\ubrir\php\activerecord\lib\DateTime.php

php 7.1

@wilforlan
Copy link

This issue has been fixed at #562

Change function to
public function setTime($hour, $minute, $second = null, $microseconds = null) { $this->flag_dirty(); call_user_func_array(array($this,'parent::setTime'),func_get_args()); }

But this change needs to be merged to master I think, its not available in new install of the library, so I think it has to be changes manually for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants