-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Fix start=0 in the pagination #44069
Conversation
It works! |
@Mich-es can you open https://issues.joomla.org/tracker/joomla-cms/44069 and click button "Tested successfully" so the test is counted. |
I have tested this item ✅ successfully on 44c8277 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069. |
1 similar comment
I have tested this item ✅ successfully on 44c8277 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069. |
It is expected, when |
I have tested this item ✅ successfully on 44c8277 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069. |
I have tested this item ✅ successfully on 62b3a63 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069. |
Just an idea, wouldn't be better to have $hideEmptyLimitstart true as default? I guess probably there are more components using pagination with hidden start=0 than those requireing this syntax... This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069. |
To get rid of all the @Fedik is it possible to add this to the current Issue? as far as I know, there will be a solution for other types of duplicate pages in Joomla in Joomla |
Nope, it's not as simple as it might seem. |
Thank you! |
Pull Request for Issue #44049 .
Summary of Changes
Fix removing of
start=0
from pagination for the first page.Testing Instructions
Visit Category Blog or another list view with pagination.
Visit second page, and check the link for first page.
Actual result BEFORE applying this Pull Request
Link contain
start=0
Expected result AFTER applying this Pull Request
Link without
start=0
Link to documentations
Please select: