-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Admin Module Latest #43216
Merged
Merged
[5.2] Admin Module Latest #43216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admin module Articles - Latest displays a list of recently added content. This is really useful on the dashboards. (especially when used together with the author filter) The list can be sorted by created or modified date but it will only ever display the created date. This PR changes the date column to display created or modified depending on the sort param.
Quy
reviewed
Apr 5, 2024
I have tested this item ✅ successfully on ce05fd6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43216. |
1 similar comment
I have tested this item ✅ successfully on ce05fd6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43216. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43216. |
Thanks @brianteeman ! |
thx |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 19, 2024
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The admin module Articles - Latest displays a list of recently added content. This is really useful on the dashboards. (especially when used together with the author filter)
The list can be sorted by created or modified date but it will only ever display the created date.
This PR changes the date column to display created or modified depending on the sort param.
Testing Instructions
Create some articles with varying created and modified dates
Change the ordering option in the module
Actual result BEFORE applying this Pull Request
The list of articles are sorted based on the selected date but the displayed date is always the created date
Expected result AFTER applying this Pull Request
The list of articles are sorted based on the selected date but the displayed date is the same as the sort
No new param
I guess this could have been done by adding a new param for the displayed date but
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed