Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Feature/New Publishing Workflow #20381

Merged
merged 424 commits into from
Aug 8, 2018

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented May 13, 2018

Hello everyone,

with the Google Summer of Code 2017 project, we implemented a new workflow extension in Joomla! 4, which replaces the current publish/unpublish/trashed/archived state. We want to implement a flexible and unlimited workflow which can be extended for other extensions, too.

Presentation at the JWC 2017: https://www.youtube.com/watch?v=5e-HECq44B0
Presentation at JAB 2018: https://youtu.be/z-TfSEggUZM

Additional Information

https://docs.joomla.org/Publishing_Workflow
https://docs.joomla.org/GSOC_2017_Project_Ideas#Project_VI:_Publishing_Workflow_in_Joomla.21

Testing Instructions

Install the PR via the Patchtester and reinstall your Joomla! or download the ZIP file (https://github.com/bembelimen/joomla-cms/archive/publishing-workflow.zip) and make a fresh installation. Afterwards go to the Article manager, there you'll find a new menu entry "Workflows", play with it around. You can also use the implemented default workflow.

Workflows will be assigned in the category parameters.

Images

grafik

grafik

grafik

Comments, tips, support would be very appreciated!

Buddhima and others added 30 commits September 8, 2017 23:41
CanDo save2copy
Code rerranged
Merge transition and state column in articles view
@brianteeman
Copy link
Contributor

I agree 100% with your observation about the similarity and confusion of using status and states although they are technically the correct terms

I will take a look at what others do in this case

@brianteeman
Copy link
Contributor

I am still getting my head around it but

The "States" which are the new "layer" in the workflow, where you define your workflow states

Could that be stages?
eg
Stage 1 create content
Stage 2 review content
Stage 3 Publish content

@wilsonge
Copy link
Contributor

wilsonge commented Aug 8, 2018

I'm going to merge this to push this forward as there are issues keeping this in sync. There's clearly several issues still to work out but people can create PRs as they go

@wilsonge wilsonge merged commit e1693bd into joomla:4.0-dev Aug 8, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 8, 2018
@brianteeman
Copy link
Contributor

For the record I dont agree with this being merged in its current state and would like to see it reverted and instead of being on a personal repo moved to a joomla-projects repo like all the others and then issues can be worked on there.

This is nowhere near mergeable

@infograf768
Copy link
Member

This PR has totally broken a new clean 4.0 installation when trying to create articles.
500 'v40_multi.wa.state_id' isn't in GROUP BY

0 Argument 1 passed to Joomla\Utilities\ArrayHelpergetColumn() must be of the type array, boolean given, called in /Applications/MAMP/htdocs/installmulti/joomla40/administrator/components/com_content/Model/ArticlesModel.php on line 483

@alikon
Copy link
Contributor

alikon commented Aug 9, 2018

  • no postgresql

@ghost
Copy link

ghost commented Aug 9, 2018

@infograf768 similar #21474

@infograf768
Copy link
Member

@franz-wohlkoenig

As I have done a fully clean install from 4.0-dev, the new tables exist here.
Issue is in code.

@ghost
Copy link

ghost commented Aug 9, 2018

a nightly didn't work so a clean Install is better?

@infograf768
Copy link
Member

My issue above is when using multilang.
Creating an issue now

@infograf768
Copy link
Member

See #21475

@brianteeman
Copy link
Contributor

Sorry but this is way beyond not ready it is not correct #21476

`asset_id` int(10) DEFAULT 0,
`published` tinyint(1) NOT NULL DEFAULT 0,
`title` varchar(255) NOT NULL,
`description` text NOT NULL DEFAULT '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MySQL 'TEXT' type cannot have a DEFAULT value (other than NULL)

KEY `created_by` (`created_by`),
KEY `modified` (`modified`),
KEY `modified_by` (`modified_by`)
) ENGINE=InnoDB COLLATE=utf8mb4_unicode_ci;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 DEFAULT COLLATE=utf8mb4_unicode_ci ?

@laoneo
Copy link
Member

laoneo commented Aug 9, 2018

Please open new issues or pull requests regarding the new workflow feature. This pr got merged and all comments will likely get forgotten.

@alikon
Copy link
Contributor

alikon commented Aug 9, 2018

ok will do, but ......

@joomla joomla locked as resolved and limited conversation to collaborators Aug 9, 2018
@@ -40,6 +40,11 @@
'version_note',
);

if ($displayData->get('item')->id !== null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bembelimen Why is this change here? This causes a notice undefined in the plugins when you edit them:
image

@brianteeman
Copy link
Contributor

Please open new issues or pull requests regarding the new workflow feature. This pr got merged and all comments will likely get forgotten.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.