Disable Chosen.js for the rule field, again

[Fedik]

Pull Request for Issue #12843 .

Summary of Changes

Revert the check for instance type of data-chosen, to allow to disable Chosen for field with data-chosen="true"

Testing Instructions

Make sure that the rule field use simple <select> input (without Chosen stylling),
and all icons "ok/loading/error" are visible again when try to change the rule value

Documentation Changes Required

none

[ralain]

I have tested this item ✅ successfully on c4fe40a

After patch is applied and browser cache cleared chosen is gone from ACL rule selects and icons are back.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12877.}

[dgrammatiko]

I have tested this item ✅ successfully on c4fe40a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12877.}

[dgrammatiko]

RTC

NOTE to whomever merge this: please ping me!

[wilsonge]

Is the only way to achieve this really with more hacks to chosen :(

[Fedik]

unfortunately,
Correct way would be apply Chosen only to "specific" <select> with specific class, eg "advancedSelect", instead of apply Chosen to all <select> on the page,

but for now it sounds like utopia 😉

[rdeutz]

@Fedik could you please remove the commented code 598-602, thanks

[rdeutz]

seems comment are the common practice, could you them please add the reason why this change was made, thanks

[Fedik]

@rdeutz ok, I will add

[Fedik]

@rdeutz added

[rdeutz]

@Fedik Thanks, merged