forked from cossacklabs/acra
-
Notifications
You must be signed in to change notification settings - Fork 0
/
utils_test.go
580 lines (516 loc) · 18.2 KB
/
utils_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
package encryptor
import (
"testing"
"github.com/cossacklabs/acra/sqlparser/dialect/mysql"
"github.com/stretchr/testify/mock"
"github.com/cossacklabs/acra/decryptor/base/mocks"
"github.com/cossacklabs/acra/encryptor/config"
"github.com/cossacklabs/acra/sqlparser"
"github.com/cossacklabs/acra/sqlparser/dialect"
"github.com/cossacklabs/acra/sqlparser/dialect/postgresql"
)
func TestGetFirstTableWithoutAlias(t *testing.T) {
type testcase struct {
SQL string
Table string
Error error
}
testcases := []testcase{
{SQL: `select * from table1, table2 t2`, Table: "table1"},
{SQL: `select * from table2 t2, table1`, Table: "table1"},
{SQL: `select * from table2 t2, table1, table3 as t3`, Table: "table1"},
{SQL: `select * from table2 t2, table1 t1, table3 as t3`, Error: errNotFoundtable},
{SQL: `select * from table1 join table2 join table3 join table4`, Table: "table1"},
{SQL: `select * from table1 t2 join table2 `, Error: errNotFoundtable},
}
parser := sqlparser.New(sqlparser.ModeStrict)
for _, tcase := range testcases {
parsed, err := parser.Parse(tcase.SQL)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test cases should contain only Select queries")
}
tableName, err := getFirstTableWithoutAlias(selectExpr.From)
if err != tcase.Error {
t.Fatal(err)
}
// if expected error then we don't need to compare table name
if tcase.Error != nil {
continue
}
if tableName != tcase.Table {
t.Fatal("Parsed incorrect table name without alias")
}
}
}
func TestMapColumnsToAliases(t *testing.T) {
parser := sqlparser.New(sqlparser.ModeStrict)
t.Run("With enumeration fields query", func(t *testing.T) {
testConfig := `
schemas:
- table: table5
columns:
- col5
encrypted:
- column: col5
- table: table6
columns:
- col6
encrypted:
- column: col6
`
schemaStore, err := config.MapTableSchemaStoreFromConfig([]byte(testConfig), config.UseMySQL)
if err != nil {
t.Fatal(err)
}
query := `
select t1.col1, t1.col2, t2.col1, t2.col2, t3.col1, t4.col4, col5, table6.col6
from table5, table6
inner join (select col1, col22 as col2, col3 from table1) as t1
inner join (select t1.col1, t2.col3 col2, t1.col3 from table1 t1 inner join table2 t2 on t1.col1=t2.col1) as t2 on t2.col1=t1.col1
inner join table3 t3 on t3.col1=t1.col1
inner join table4 as t4 on t4.col4=t1.col4
inner join table6 on table6.col1=t1.col1
`
expectedValues := []ColumnInfo{
// column's alias is subquery alias with column and table without aliases in subquery
{Alias: "t1", Table: "table1", Name: "col1"},
// column's alias is subquery alias with column with AS expression and table without alias
{Alias: "t1", Table: "table1", Name: "col22"},
// column's alias is subquery alias and column name has alias in subquery to table with alias
{Alias: "t2", Table: "table1", Name: "col1"},
// column's alias is subquery alias and column name has alias in subquery to joined table with alias
{Alias: "t2", Table: "table2", Name: "col3"},
// column's alias is alias of joined table
{Alias: "t3", Table: "table3", Name: "col1"},
// column's alias is alias of joined table with AS expression
{Alias: "t4", Table: "table4", Name: "col4"},
// column without alias of table in FROM expression
{Table: "table5", Name: "col5", Alias: "table5"},
// column with alias as table name in FROM expression
{Table: "table6", Name: "col6", Alias: "table6"},
}
parsed, err := parser.Parse(query)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test query should be Select expression")
}
columns, err := MapColumnsToAliases(selectExpr, schemaStore)
if err != nil {
t.Fatal(err)
}
if len(columns) != len(expectedValues) {
t.Fatal("Returned incorrect length of values")
}
for i, column := range columns {
if column == nil {
t.Fatalf("[%d] Column info not found", i)
}
if *column != expectedValues[i] {
t.Fatalf("[%d] Column info is not equal to expected - %+v, actual - %+v", i, expectedValues[i], *column)
}
}
})
t.Run("with aliased table and non-aliased colum name", func(t *testing.T) {
testConfig := `
schemas:
- table: users
columns:
- id
- email
- mobile_number
encrypted:
- column: id
- table: users_duplicate
columns:
- id
- email
- mobile_number
encrypted:
- column: id
- table: users_temp
columns:
- id_tmp
- email_tmp
- mobile_number_tmp
encrypted:
- column: id_tmp
`
schemaStore, err := config.MapTableSchemaStoreFromConfig([]byte(testConfig), config.UseMySQL)
if err != nil {
t.Fatal(err)
}
testcases := []struct {
query string
dialect dialect.Dialect
expectedValues []*ColumnInfo
}{
{
query: `SELECT "id", "email", "mobile_number" AS "mobileNumber" FROM "users" AS "User" where "User"."is_active"`,
expectedValues: []*ColumnInfo{
{Alias: "User", Table: "users", Name: "id"},
{Alias: "User", Table: "users", Name: "email"},
{Alias: "User", Table: "users", Name: "mobile_number"},
},
},
{
query: `SELECT "id", "email", "mobile_number" AS "mobileNumber" FROM "users" AS "User", "table1" as "test_table"`,
expectedValues: []*ColumnInfo{
{Alias: "User", Table: "users", Name: "id"},
{Alias: "User", Table: "users", Name: "email"},
{Alias: "User", Table: "users", Name: "mobile_number"},
},
},
{
query: `SELECT "id", "email", "mobile_number" AS "mobileNumber" FROM "users" AS "User", "users_duplicate" as "User2"`,
expectedValues: []*ColumnInfo{
nil, nil, nil,
},
},
{
query: `SELECT "id", "email", "mobile_number", "id_tmp", "email_tmp", "mobile_number_tmp" AS "mobileNumber" FROM "users" AS "User", "users_temp" as "temp"`,
expectedValues: []*ColumnInfo{
{Alias: "User", Table: "users", Name: "id"},
{Alias: "User", Table: "users", Name: "email"},
{Alias: "User", Table: "users", Name: "mobile_number"},
{Alias: "temp", Table: "users_temp", Name: "id_tmp"},
{Alias: "temp", Table: "users_temp", Name: "email_tmp"},
{Alias: "temp", Table: "users_temp", Name: "mobile_number_tmp"},
},
},
{
query: `SELECT id, email, mobile_number FROM users AS alias where alias.is_active`,
dialect: mysql.NewMySQLDialect(),
expectedValues: []*ColumnInfo{
{Alias: "alias", Table: "users", Name: "id"},
{Alias: "alias", Table: "users", Name: "email"},
{Alias: "alias", Table: "users", Name: "mobile_number"},
},
},
{
// should return nil, nil, nil as all the columns present in both tables which is invalid
query: `SELECT id, email, mobile_number FROM users, users_duplicate`,
dialect: mysql.NewMySQLDialect(),
expectedValues: []*ColumnInfo{
nil, nil, nil,
},
},
}
for i, tcase := range testcases {
var dialect dialect.Dialect = postgresql.NewPostgreSQLDialect()
if tcase.dialect != nil {
dialect = tcase.dialect
}
sqlparser.SetDefaultDialect(dialect)
parsed, err := parser.Parse(tcase.query)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test query should be Select expression")
}
columns, err := MapColumnsToAliases(selectExpr, schemaStore)
if err != nil {
t.Fatal(err)
}
if len(columns) != len(tcase.expectedValues) {
t.Fatal("Returned incorrect length of values")
}
for y, column := range columns {
if column == nil {
if tcase.expectedValues[y] != nil {
t.Fatalf("[%d] expected nil column value ", i)
}
continue
}
if *column != *tcase.expectedValues[y] {
t.Fatalf("[%d] Column info is not equal to expected - %+v, actual - %+v", i, tcase.expectedValues[i], *column)
}
}
}
})
t.Run("Join enumeration fields query", func(t *testing.T) {
queries := []string{
`select table1.number, from_number, to_number, type, amount, created_date
from table1 join table2 as t2 on from_number = t2.number or to_number = t2.number join users as u on t2.user_id = u.id`,
// select with revers order of JOINs declaration
`select t3.*, t1.*, t2.*
from table1 AS t1 join table2 as t2 on from_number = t2.number or to_number = t2.number join table3 as t3 on t2.user_id = t3.id`,
// case with multiple table JOIN block ParenTableExpr
`select t1.number AS t1_number, t2.number AS t2_number from (select * from tablex) AS t JOIN (table1 AS t1 JOIN table2 AS t2 ON t1.id = t2.exam_type_id) ON t.version_id =
t1.version_id`,
// example with several multiple table JOIN blocks ParenTableExpr
`select t1.number AS t1_number, t2.number, t3.number, t4.number from (select * from tablex) AS t JOIN (table1 AS t1 JOIN table2 AS t2 ON t1.id = t2.exam_type_id) ON t.version_id =
t1.version_id JOIN (table3 AS t3 JOIN table4 AS t4 ON t3.id = t4.exam_type_id) ON t.version_id =
t3.version_id`,
// case with multiple table JOIN block with more tables inside
`select t1.number AS t1_number, t2.number, t3.number, t4.number from (select * from tablex) AS t JOIN (table1 AS t1 JOIN table2 AS t2 JOIN table3 as t3 JOIN table4 as t4 ON t1.id = t2.exam_type_id) ON t.version_id =
t1.version_id`,
}
expectedValues := [][]ColumnInfo{
{
{Alias: "table1", Table: "table1", Name: "number"},
{Alias: "table1", Table: "table1", Name: "from_number"},
{Alias: "table1", Table: "table1", Name: "to_number"},
{Alias: "table1", Table: "table1", Name: "type"},
{Alias: "table1", Table: "table1", Name: "amount"},
{Alias: "table1", Table: "table1", Name: "created_date"},
},
{
{Alias: allColumnsName, Table: "table3", Name: allColumnsName},
{Alias: allColumnsName, Table: "table1", Name: allColumnsName},
{Alias: allColumnsName, Table: "table2", Name: allColumnsName},
},
{
{Alias: "t1", Table: "table1", Name: "number"},
{Alias: "t2", Table: "table2", Name: "number"},
},
{
{Alias: "t1", Table: "table1", Name: "number"},
{Alias: "t2", Table: "table2", Name: "number"},
{Alias: "t3", Table: "table3", Name: "number"},
{Alias: "t4", Table: "table4", Name: "number"},
},
{
{Alias: "t1", Table: "table1", Name: "number"},
{Alias: "t2", Table: "table2", Name: "number"},
{Alias: "t3", Table: "table3", Name: "number"},
{Alias: "t4", Table: "table4", Name: "number"},
},
}
for i, query := range queries {
parsed, err := parser.Parse(query)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test query should be Select expression")
}
columns, err := MapColumnsToAliases(selectExpr, &config.MapTableSchemaStore{})
if err != nil {
t.Fatal(err)
}
if len(columns) != len(expectedValues[i]) {
t.Fatal("Returned incorrect length of values")
}
for c, column := range columns {
if column == nil {
t.Fatalf("[%d] Column info not found", i)
}
if *column != expectedValues[i][c] {
t.Fatalf("[%d] Column info is not equal to expected - %+v, actual - %+v", i, expectedValues[i][c], *column)
}
}
}
})
t.Run("Join enumeration asterisk query", func(t *testing.T) {
queries := []string{
`select * from test_table join test_table2 join test_table3 t3 on t2.id = t3.id join test_table4 t4 on t3.id = t4.id`,
`select t2.*, t3.* from test_table join test_table2 t2 join test_table3 t3 on t2.id = t3.id join test_table4 t4 on t3.id = t4.id`,
`select t2.*, t3.*, * from test_table join test_table2 t2 join test_table3 t3 on t2.id = t3.id join test_table4 t4 on t3.id = t4.id`,
}
expectedValues := [][]ColumnInfo{
{
{Alias: allColumnsName, Table: "test_table", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table2", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table3", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table4", Name: allColumnsName},
},
{
{Alias: allColumnsName, Table: "test_table2", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table3", Name: allColumnsName},
},
{
{Alias: allColumnsName, Table: "test_table2", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table3", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table2", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table3", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table4", Name: allColumnsName},
},
}
for i, query := range queries {
parsed, err := parser.Parse(query)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test query should be Select expression")
}
columns, err := MapColumnsToAliases(selectExpr, &config.MapTableSchemaStore{})
if err != nil {
t.Fatal(err)
}
if len(columns) != len(expectedValues[i]) {
t.Fatal("Returned incorrect length of values")
}
for c, column := range columns {
if column == nil {
t.Fatalf("[%d] Column info not found", i)
}
if *column != expectedValues[i][c] {
t.Fatalf("[%d] Column info is not equal to expected - %+v, actual - %+v", i, expectedValues[i][c], *column)
}
}
}
})
t.Run("With asterisk query", func(t *testing.T) {
query := `select * from test_table`
parsed, err := parser.Parse(query)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test query should be Select expression")
}
expectedValue := ColumnInfo{Alias: "*", Table: "test_table", Name: "*"}
columns, err := MapColumnsToAliases(selectExpr, &config.MapTableSchemaStore{})
if err != nil {
t.Fatal(err)
}
if len(columns) != 1 {
t.Fatal("Returned incorrect length of values")
}
column := columns[0]
if column == nil {
t.Fatal("Column info not found")
}
if *column != expectedValue {
t.Fatalf("Column info is not equal to expected - %+v, actual - %+v", expectedValue, *column)
}
})
t.Run("Asterisk query with subQuery", func(t *testing.T) {
testConfig := `
schemas:
- table: table2
columns:
- value
encrypted:
- column: value
- table: table3
columns:
- value
encrypted:
- column: value
`
schemaStore, err := config.MapTableSchemaStoreFromConfig([]byte(testConfig), config.UseMySQL)
if err != nil {
t.Fatal(err)
}
queries := []string{
`select (select value from table2), (select value from table3), * from table1;`,
}
// TODO: consider tracking queries with asterisk from sub-queries as we need to map it via encryptor config
// e.g select anon.value_table1, anon.value_table2 from (select * from table1 as tb1 JOIN table2 AS tb2 ON tb1.id = tb2.id) as anon;
expectedValues := [][]ColumnInfo{
{
{Alias: "table2", Table: "table2", Name: "value"},
{Alias: "table3", Table: "table3", Name: "value"},
{Alias: allColumnsName, Table: "table1", Name: allColumnsName},
},
}
for i, query := range queries {
parsed, err := parser.Parse(query)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test query should be Select expression")
}
columns, err := MapColumnsToAliases(selectExpr, schemaStore)
if err != nil {
t.Fatal(err)
}
if len(columns) != len(expectedValues[i]) {
t.Fatal("Returned incorrect length of values")
}
for c, column := range columns {
if column == nil {
t.Fatalf("[%d] Column info not found", i)
}
if *column != expectedValues[i][c] {
t.Fatalf("[%d] Column info is not equal to expected - %+v, actual - %+v", i, expectedValues[i][c], *column)
}
}
}
})
t.Run("With table asterisk query", func(t *testing.T) {
query := `select t1.*, t2.* from test_table t1, test_table t2`
parsed, err := parser.Parse(query)
if err != nil {
t.Fatal(err)
}
selectExpr, ok := parsed.(*sqlparser.Select)
if !ok {
t.Fatal("Test query should be Select expression")
}
expectedValue := []ColumnInfo{
{Alias: allColumnsName, Table: "test_table", Name: allColumnsName},
{Alias: allColumnsName, Table: "test_table", Name: allColumnsName},
}
columns, err := MapColumnsToAliases(selectExpr, &config.MapTableSchemaStore{})
if err != nil {
t.Fatal(err)
}
if len(columns) != len(expectedValue) {
t.Fatal("Returned incorrect length of values")
}
for i, expectedColumn := range expectedValue {
if columns[i].Name != expectedColumn.Name || columns[i].Alias != expectedColumn.Alias || columns[i].Table != expectedColumn.Table {
t.Fatalf("Column info is not equal to expected - %+v, actual - %+v", expectedValue, columns[i])
}
}
})
}
func TestPlaceholderSettings(t *testing.T) {
clientSession := &mocks.ClientSession{}
sessionData := make(map[string]interface{}, 2)
clientSession.On("GetData", mock.Anything).Return(func(key string) interface{} {
return sessionData[key]
}, func(key string) bool {
_, ok := sessionData[key]
return ok
})
clientSession.On("DeleteData", mock.Anything).Run(func(args mock.Arguments) {
delete(sessionData, args[0].(string))
})
clientSession.On("SetData", mock.Anything, mock.Anything).Run(func(args mock.Arguments) {
sessionData[args[0].(string)] = args[1]
})
sessionData[placeholdersSettingKey] = "trash"
data := PlaceholderSettingsFromClientSession(clientSession)
if data != nil {
t.Fatal("Expect nil for value with invalid type")
}
DeletePlaceholderSettingsFromClientSession(clientSession)
// get new initialized map
data = PlaceholderSettingsFromClientSession(clientSession)
// set some data
data[0] = &config.BasicColumnEncryptionSetting{}
data[1] = &config.BasicColumnEncryptionSetting{}
newData := PlaceholderSettingsFromClientSession(clientSession)
if len(newData) != len(data) {
t.Fatal("Unexpected map with different size")
}
// clear data, force to return map to the pool cleared from data
DeletePlaceholderSettingsFromClientSession(clientSession)
// we expect that will be returned same value from sync.Pool and check that it's cleared
newData = PlaceholderSettingsFromClientSession(clientSession)
if len(newData) != 0 {
t.Fatal("Map's data wasn't cleared")
}
if len(newData) != len(data) {
t.Fatal("Source map's data wasn't cleared")
}
}