Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid call mixin in Less #133

Closed
mrmlnc opened this issue Jan 3, 2016 · 2 comments
Closed

Invalid call mixin in Less #133

mrmlnc opened this issue Jan 3, 2016 · 2 comments
Assignees
Labels

Comments

@mrmlnc
Copy link

mrmlnc commented Jan 3, 2016

Hi,

I wrote the following configuration:

mode: {
  sprite: 'sprite.svg',
  css: {
    dest: 'styles/'
    common: 'icon',
    prefix: '.icon-',
    dimensions: '-wh',
    sprite: '../images/sprite.svg',
    bust: false,
    mixin: 'sprite-icon',
    render: {
      less: true
    }
  }
}

Gulp plugin generated for me this code:

.sprite-icon() {
    background: url("../images/sprite.svg") no-repeat;
}
.icon {
    sprite-icon();  // here is missing the dot
}
// More icons
// ...

If I specify a dot in the property mode.<mode>.mixin (mixin: '.sprite-icon'), then:

..sprite-icon() { // here two dots
    background: url("../images/sprite.svg") no-repeat;
}
.icon {
    .sprite-icon();
}
// More icons
// ...
@jkphl jkphl added the bug label Jan 4, 2016
@jkphl jkphl self-assigned this Jan 4, 2016
@jkphl jkphl closed this as completed in 79293fd Jan 5, 2016
@mrmlnc
Copy link
Author

mrmlnc commented Jan 5, 2016

Good sounds!

@jkphl
Copy link
Collaborator

jkphl commented Jan 5, 2016

@mrmlnc Yep, should be fixed as of 1.2.18 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants