Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purges in private channels get logged to mod-log #18

Open
khionu opened this issue Sep 26, 2018 · 7 comments
Open

Purges in private channels get logged to mod-log #18

khionu opened this issue Sep 26, 2018 · 7 comments

Comments

@khionu
Copy link

khionu commented Sep 26, 2018

I'm not sure how you would like to handle this, but there should be some way to use message purging without it leaking from private channels to public.

@Shengaero
Copy link

This might be best with a channel configuration.

Something like >>clean ignore or >>modlog ignore methinks 🤔

I would appreciate this feature too, seems like a must tbh

@Artuto
Copy link
Contributor

Artuto commented Sep 26, 2018

It could be done like I do it on Endless (which isnt the best way to but...). With a tag in the channel topic.

@jagrosh
Copy link
Owner

jagrosh commented Sep 26, 2018

If anything, I would probably do it identical to the current system for not logging messages in a channel; set a channel-level user override for Read Message History for vortex.

@khionu
Copy link
Author

khionu commented Sep 27, 2018

But that would disable purging all together, would it not? I just want to avoid it getting logged publically

@jagrosh
Copy link
Owner

jagrosh commented Sep 28, 2018

If Vortex has the Admin permission, it wouldn't disable it (for not logging message edits/deletes for a channel, Vortex looks specifically for the override - not for if it actually has permission). That being said, you're right, it would break usage of the command if Vortex does not have Admin.

@khionu
Copy link
Author

khionu commented Sep 29, 2018

So, do you see that issue as something worth fixing?

@jagrosh
Copy link
Owner

jagrosh commented Feb 4, 2019

I've been thinking about this some more, and I think a solution that would solve this (as well as another related request) would be to add both of the following:

  • Channels where an explicit permission denial for Vortex (user-level permission override) on Read Message History would cause the modlog entry for >>clean to contain the same moderator info (who cleaned, what the parameters were) but without any link to the cleaned messages. This goes hand-in-hand with the existing system where the same permission denial will cause Vortex to not log deleted/edited messages in these channels to the messagelog.
  • An additional modlog setting that allows disabling the view/download links for cleaning entirely. >>clean commands would still be logged (moderator, cleaning parameters), just the messages would not be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants