Skip to content

Commit

Permalink
compileall tests: Use shorter name for long_path test (pythonGH-16419)
Browse files Browse the repository at this point in the history
Apparently, the path needs to be limited to 260 characters on
(some versions of) Windows.
  • Loading branch information
encukou authored and Jake Taylor committed Dec 5, 2019
1 parent 1e27dd3 commit 6644e67
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Lib/test/test_compileall.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def create_long_path(self):
# It will be 100 directories deep, or shorter if the OS limits it.
for i in range(10):
longer_path = os.path.join(
long_path, *(f"long_directory_{i}_{j}" for j in range(10))
long_path, *(f"dir_{i}_{j}" for j in range(10))
)

# Check if we can open __pycache__/*.pyc.
Expand Down Expand Up @@ -87,8 +87,12 @@ def create_long_path(self):
long_source = longer_source
long_cache = longer_cache

# On Windows, MAX_PATH is 260 characters, our path with the 20
# directories is 160 characters long, leaving something for the
# root (self.directory) as well.
# Tests assume long_path contains at least 10 directories.
if i < 2:
raise ValueError('Path limit is too short')
raise ValueError(f'"Long path" is too short: {long_path}')

self.source_path_long = long_source
self.bc_path_long = long_cache
Expand Down

0 comments on commit 6644e67

Please sign in to comment.