Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup pwa capabilities and favicons PR (#10) #47

Merged
merged 5 commits into from
Aug 31, 2022
Merged

setup pwa capabilities and favicons PR (#10) #47

merged 5 commits into from
Aug 31, 2022

Conversation

LemmyMwaura
Copy link
Contributor

Description

Added PWA capabilities to the app and setup dynamic favicons (depends on screen size)(#10)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Npm Peer Dependency Conflict

  • angular/service-worker installation had some peer dependency conflicts with a few angular packages e.g angular/common. To fix the installation, I had to ignore peer dependencies by adding --legacy-peer-deps flags to the installation command
  • This will therefore be a requirement for all future installs.
    • npm install @angular/service-worker --legacy-peer-deps
  • Everything else works as expected

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code

@jrosseel jrosseel merged commit a13ebc0 into italanta:main Aug 31, 2022
@pmutua pmutua mentioned this pull request Aug 31, 2022
@LemmyMwaura LemmyMwaura deleted the feat-pwa-favicon-#10 branch August 31, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants