✨ video upload modal #336 #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 6, 2023 12:58
…data Adding the code to open a modal and exchange data using mat_dialog_data
|
@LemmyMwaura , I have opened a new PR without the rebased files, please see this. |
...s/blocks/library/video-message-block/src/lib/components/video-block/video-block.component.ts
Show resolved
Hide resolved
| } | ||
|
|
||
| async processVideo(event: any) { | ||
| if (event.target.files && event.target.files[0]) { |
There was a problem hiding this comment.
Add comments here to clarify what is happening
There was a problem hiding this comment.
Cool, working on this, I will let you know when it is done @njoroge-jane
njoroge-jane
requested changes
Apr 17, 2023
There was a problem hiding this comment.
@Beulah-Matt Great Job!
A few things to work on for the general UI:
- The color of the modal heading and the pixel options should match be as per the design
- The input for the name and the media input field should be of the same length even after the thumbnail has been uploaded.
- The spacing around the modal should be as per design
NB: Kindly attach a video of the entire uploading process.
…-video-upload-modal
LemmyMwaura
approved these changes
May 12, 2023
ReaganCn
approved these changes
May 15, 2023
njoroge-jane
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have implemented a video modal with a
-Title
-Name inputs
-A thumbnail image
-Radio check marks to select video resolution.
On clicking the play button in the video block, you are redirected to this modal.
When you click on the thumbnail, a file explorer window is opened to select a video file
Currently, you are able to see the video in the modal in place of the thumbnail and the URL is prepopulated under the video link input.
Fixes #336
Type of change
Please delete options that are not relevant.
#Screenshot
Screencast from 11-05-23 19:41:17.webm
Checklist: