Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 App Design: Sign up Page #391

Merged
merged 11 commits into from
Apr 17, 2023
Merged

Conversation

Michael-Otieno
Copy link
Contributor

@Michael-Otieno Michael-Otieno commented Mar 31, 2023

Description

I worked alone.

This pull request solves issue #383, whereby I have redesigned the Signup Page following the design's guidelines.

Fixes #383

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshot (optional)

a.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Michael-Otieno
Copy link
Contributor Author

Waiting for review @LemmyMwaura

Copy link
Member

@ReaganCn ReaganCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Please share a video on scrolling of the signup page. It was cutting out on the bottom when scrolling(screenshot on the issue description).

@Michael-Otieno
Copy link
Contributor Author

Michael-Otieno commented Apr 4, 2023

Good work. Please share a video on scrolling of the signup page. It was cutting out on the bottom when scrolling(screenshot on the issue description).

The page has no scroll. It covers the whole screen with no scroll @ReaganCn waiting for review

@ReaganCn
Copy link
Member

ReaganCn commented Apr 6, 2023

Also there was no need to update these. This issue was design only.
image

Copy link
Member

@ReaganCn ReaganCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there was no need to update these. This issue was design only.
image

@Michael-Otieno
Copy link
Contributor Author

Code updated. Waiting for review @ReaganCn

@ReaganCn ReaganCn merged commit fac6b3a into italanta:develop Apr 17, 2023
@ReaganCn
Copy link
Member

@Michael-Otieno Are you in the Moringa slack channel. What is your handle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎨 App Design: Sign up Page
2 participants