Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨🔢 Set limit to number of characters and possible options on question and list block options #321

Merged
merged 7 commits into from
Feb 28, 2023
Merged

🎨🔢 Set limit to number of characters and possible options on question and list block options #321

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
33c62bf
:sparkles: feat: Add option input maxlength validation and error message
royokite Feb 23, 2023
0b8dc8b
:sparkles: feat: Add limit to number of options possible and input size
royokite Feb 23, 2023
f5bef24
:sparkles: feat: Add limit to possible options and input size
royokite Feb 23, 2023
33f1dd6
:lipstick: style: Add styling to custom warning message
royokite Feb 23, 2023
68f5b53
Merge branch 'main' into main
royokite Feb 23, 2023
801fd2b
:recycle: refactor: Use multi-lang on option component error message
royokite Feb 23, 2023
1dc47dc
:recycle: refactor: Move limit values to constant variables.
royokite Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
✨ feat: Add option input maxlength validation and error message 
Add maxlength variable to option component.
Add custom error message to display on invalid input
  • Loading branch information
@royokite
royokite committed Feb 23, 2023
commit 33c62bf25198cf98e0d4e2bea65928a885813f42
5 changes: 4 additions & 1 deletion ...ary/block-options/src/lib/components/option-input-field/option-input-field.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
<div [formGroupName]="formGroupNameInput" class="option" fxFlex>
<input [id]="inputUniqueId" [class]="optionClass" [readOnly]="isReadOnly"
[ngClass]="isReadOnly? 'readonly' : ''" formControlName="message"
type="text" placeholder="Click here to edit" fxFlexFill>
type="text" placeholder="Click here to edit" [maxlength]="charMaxlength" [(ngModel)]="optionValue" fxFlexFill>
<span class="length-error" *ngIf="optionValue.length >= charMaxlength">
maximum characters reached
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use multi-lang. Have a look at the below from the login.component.html
image

The translations are added in the files en.json and fr.json

</span>
</div>
</div>
</div>
Expand Down
16 changes: 7 additions & 9 deletions ...brary/block-options/src/lib/components/option-input-field/option-input-field.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,32 @@ import { _JsPlumbComponentDecorator } from '../../providers/jsplumb-decorator.fu
templateUrl: './option-input-field.component.html',
styleUrls: ['./option-input-field.component.scss'],
})
export class OptionInputFieldComponent implements OnInit, AfterViewInit
{
export class OptionInputFieldComponent implements OnInit, AfterViewInit {

@Input() blockFormGroup: FormGroup;
@Input() formGroupNameInput: number | string;
@Input() jsPlumb: BrowserJsPlumbInstance;
@Input() optionClass: string;
@Input() isEndpoint: boolean;
@Input() isReadOnly: boolean;
@Input() charMaxlength: number;

inputUniqueId: string;
optionValue: string = "";

constructor() {}
constructor() { }

ngOnInit(): void
{
ngOnInit(): void {
if (this.isEndpoint) {
this.inputUniqueId = `i-${this.formGroupNameInput}-${this.blockFormGroup.value.id}`;
}
}

ngAfterViewInit(): void
{
ngAfterViewInit(): void {
this._decorateInput();
}

private _decorateInput()
{
private _decorateInput() {
let input = document.getElementById(this.inputUniqueId) as Element;
if (this.jsPlumb) {
input = _JsPlumbComponentDecorator(input, this.jsPlumb);
Expand Down