🎨🔢 Set limit to number of characters and possible options on question and list block options #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add maxlength variable to option component. Add custom error message to display on invalid input
Limit the options a user can add to question blocks to 3. Add limit to input size set to 20.
Limit input size to 24 characters Limit possible options to 10
Set font color to red Set font size to x-small Set flex direction on container to flex column
ReaganCn
requested changes
Feb 23, 2023
| type="text" placeholder="Click here to edit" fxFlexFill> | ||
| type="text" placeholder="Click here to edit" [maxlength]="charMaxlength" [(ngModel)]="optionValue" fxFlexFill> | ||
| <span class="length-error" *ngIf="optionValue.length >= charMaxlength"> | ||
| maximum characters reached |
There was a problem hiding this comment.
Please use multi-lang. Have a look at the below from the login.component.html
The translations are added in the files en.json and fr.json
| @@ -45,9 +45,9 @@ export class ListBlockComponent<T> implements OnInit, AfterViewInit { | |||
| } | |||
|
|
|||
| addNewOption() { | |||
| this.listItems.push(this.addListOptions()); | |||
| if (this.listItems.length < 10) this.listItems.push(this.addListOptions()); | |||
| @@ -10,7 +10,7 @@ | |||
| <div [formGroupName]="i" class="inputList" fxLayout="row" fxLayoutALign="start center" fxFlex="100"> | |||
| <button (click)="deleteInput(i)" class="listgone"><i class="far fa-trash-alt"></i></button> | |||
| <app-option-input-field [jsPlumb]="jsPlumb" [blockFormGroup]="questionMessageBlock" [formGroupNameInput]="i" | |||
| class="input"></app-option-input-field> | |||
| class="input" [charMaxlength]=20></app-option-input-field> | |||
| @@ -49,7 +49,7 @@ export class QuestionsBlockComponent implements OnInit, AfterViewInit { | |||
| } | |||
|
|
|||
| addNewOption() { | |||
| this.options.push(this.addQuestionOptions()); | |||
| if (this.options.length < 3) this.options.push(this.addQuestionOptions()); | |||
There was a problem hiding this comment.
Made all the requested changes. @ReaganCn
Update the en and fr json files for translation purposes.
Move the input max length value to constant Move the array limit size to constant.
ReaganCn
approved these changes
Feb 27, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is made in part to handle number of options and character limit on the question and list blocks.
For the list block:
For the question block
Fixes #302
Type of change
Please delete options that are not relevant.
Screenshot (optional)
How Has This Been Tested?
Checklist: