Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Edit a Bot #103 #113

Merged
merged 36 commits into from
Nov 8, 2022
Merged

✨ Edit a Bot #103 #113

merged 36 commits into from
Nov 8, 2022

Conversation

AnnaL001
Copy link
Contributor

@AnnaL001 AnnaL001 commented Oct 26, 2022 •
edited
Loading

Description

Adds a feature that allows for editing of a bot's details; name and description.

The feature includes the following:

  • Edit bot form opens when the "Edit" bot menu actions item is selected.
  • Edit bot form opens with the specified title and submit button text.
  • Edit bot form is populated with the current bot details when the dialog is opened.
  • Changes to bot details are saved when clicking the button with the text "Update Bot".

Fixes #103.

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshot

Screenshot from 2022-11-03 11-50-55

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

IanOdhiambo9
IanOdhiambo9 requested changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@IanOdhiambo9 IanOdhiambo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find time to schedule a call with me to go over this together.

apps/conv-learning-manager/src/app/app.module.ts Outdated
Comment on lines 29 to 30
import { environment } from '../environments/environments';
import { environment } from '../environments/environment';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please gitignore your environments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change has been made

apps/conv-learning-manager/src/main.ts Outdated
Comment on lines 3 to 6

import { AppModule } from './app/app.module';
import { environment } from './environments/environments';
import { environment } from './environments/environment';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore environments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change has been made

@AnnaL001 AnnaL001 closed this Nov 7, 2022
@AnnaL001 AnnaL001 reopened this Nov 7, 2022
IanOdhiambo9
IanOdhiambo9 approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@IanOdhiambo9 IanOdhiambo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@IanOdhiambo9 IanOdhiambo9 merged commit 7bc24fb into italanta:main Nov 8, 2022
@IanOdhiambo9 IanOdhiambo9 added the 4-pointer+ Moderate class issue - 4 bounty points label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanOdhiambo9 IanOdhiambo9 IanOdhiambo9 approved these changes

Assignees
No one assigned
Labels
4-pointer+ Moderate class issue - 4 bounty points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Edit a Bot
2 participants
@AnnaL001 @IanOdhiambo9