Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 🔗 Connection Bug: Deleting block with connections #424

Closed
njoroge-jane opened this issue Apr 14, 2023 · 1 comment · Fixed by #490
Closed

🐛 🔗 Connection Bug: Deleting block with connections #424

njoroge-jane opened this issue Apr 14, 2023 · 1 comment · Fixed by #490
Labels
2-pointer simple class issue - 2 bounty points bug Something isn't working

Comments

@njoroge-jane
Copy link
Collaborator

njoroge-jane commented Apr 14, 2023

Describe the bug

When deleting an unsaved block in the CLM editor, the connections seem to be grouping together in a strange way, resulting in a cluttered and unclear connection.

To Reproduce
Steps to reproduce the behaviour:

  1. Log in to CLM
  2. Navigate to the content block you want to delete
  3. Click on the "Delete" button for that block
  4. Notice that while the unsaved block is deleted, the connections of that block do not disappear, and instead seem to be grouped together in an unexpected way, resulting in a cluttered and unclear connection.

Expected behaviour
The deletion of a block should also delete or remove its connections whether it's saved in the database or not. To achieve this we'll have to remove our deleted connections from the state layer and not the database.

Screenshots
N/A

Desktop

  • OS: Windows 10
  • Browser: Google Chrome Version 90.0.4430.93 (Official Build) (64-bit)
  • Version: CLM v2.3.1

Smartphone
N/A

Additional context
How the flow works currently is when a block and connection is created then saved the deletion of the block triggers the deletion of its connections.

Note:
When a saved block is deleted the connections clutter for a second then they are deleted and therefore no more clutter.
A better solution to handle this behaviour should be considered.

@jrosseel jrosseel added 2-pointer simple class issue - 2 bounty points bug Something isn't working labels May 10, 2023
@Beulah-Matt
Copy link
Collaborator

Working on this.

LemmyMwaura added a commit that referenced this issue May 22, 2023
…th_connections

🐛 fix deleted blocks connection bug when a story is not saved #424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-pointer simple class issue - 2 bounty points bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants