From c3180ad17eb999964062209354ff599df8459f0f Mon Sep 17 00:00:00 2001 From: Andy Pan Date: Fri, 10 Jul 2020 00:56:32 +0800 Subject: [PATCH] test: fix a few issues in TestLengthFieldBasedFrameCodecZeroPlayLoad Updates #113 --- codec_test.go | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/codec_test.go b/codec_test.go index 57d84f227..324ab7106 100644 --- a/codec_test.go +++ b/codec_test.go @@ -309,18 +309,15 @@ func TestLengthFieldBasedFrameCodecZeroPlayLoad(t *testing.T) { InitialBytesToStrip: 4, } codec := NewLengthFieldBasedFrameCodec(encoderConfig, decoderConfig) - sz := 0 - data := make([]byte, sz) - if _, err := rand.Read(data); err != nil { - panic(err) - } - encoded, _ := codec.Encode(nil, data) - if string(encoded[4:]) != string(data) { - t.Fatalf("data don't match with big endian, raw data: %s, encoded data: %s\n", string(data), string(encoded)) + out, _ := codec.Encode(nil, nil) + if len(out[4:]) != 0 { + t.Fatalf("encoded data should be empty, but got: %s\n", string(out[4:])) } - decoded, err := codec.Decode(&mockConn{buf: encoded}) + res, err := codec.Decode(&mockConn{buf: out}) if err != nil { - t.Fatalf("decode error raw data: %s , decoded data: %s\n", string(encoded), string(decoded)) + t.Fatalf("decode error with error: %v\n", err) + }else if len(res) != 0{ + t.Fatalf("decoded data should be empty, but got: %s\n", string(res[4:])) } }