Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep_hyp3: support burst-wide interferograms from hyp3-isce2 #1074

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

cirrusasf
Copy link
Contributor

@cirrusasf cirrusasf commented Aug 22, 2023

… analysis with mintpy

Description of proposed changes

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@yunjunz
Copy link
Member

yunjunz commented Aug 23, 2023

Thank you @cirrusasf for the PR. I am excited to see the burst interferogram going forward. Could you provide an example description of the directory structure, including the actual file names, for the burst interferograms? I assume it's similar to https://mintpy.readthedocs.io/en/latest/dir_structure/#asf_hyp3.

@yunjunz yunjunz changed the title modify prep_hyp3.py to prepare hyp3-isce2 burst pairs for time series… prep_hyp3: support burst-wide interferograms from hyp3-isce2 Aug 24, 2023
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for my comment above. The rest looks all good to me.

@forrestfwilliams
Copy link
Collaborator

Hey @yunjunz thanks for the review. This all looks good to me. I believe @cirrusasf has added the directory structure info you requested and I like using the presence of IW to determine if the product is a burst product. Anything else you'd like to see before merging?

@yunjunz
Copy link
Member

yunjunz commented Aug 25, 2023

Thanks @forrestfwilliams. That's all for this PR. After the service went online, it would be helpful to prepare a small example dataset, similar to RidgecrestSenDT71 and FernandinaSenDT128, for two benefits: 1) users could learn from this dataset to organize their files and directories and grab a idea of what to expect from hyp3+mintpy workflow; 2) if the dataset is small, we could add it to the integration test in mintpy.

@yunjunz yunjunz merged commit 1493c9a into insarlab:main Aug 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants