Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isce_utils: add filter_goldstein() #1058

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 6, 2023

Description of proposed changes

  • utils.isce_utils: add/wrap filter_goldstein() from isce2 for easy reuse.

  • utils.isce_utils.unwrap_snaphu(): rename defo_max to max_defo to be more intuitive

  • cli/view.py: print out warning msg if --faultline is specified for radar-coded file

  • docs/api/data_structure.md: update syntax

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ utils.isce_utils: add/wrap filter_goldstein() from isce2 for easy reuse.

+ utils.isce_utils.unwrap_snaphu(): rename defo_max to max_defo to be more intuitive

+ cli/view.py: print out warning msg if --faultline if specified for radar-coded file

+ docs/api/data_structure.md: update syntax
@yunjunz yunjunz merged commit 5d330ad into insarlab:main Aug 6, 2023
4 checks passed
@yunjunz yunjunz deleted the goldstein branch August 6, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant