Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved 'system' inputs out as individual inputs #4406

Merged

Conversation

sdomino
Copy link
Contributor

@sdomino sdomino commented Jul 10, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This is in response to a comment made in #4290. Associated docs update here.

I wasn't sure whether to separate net and netstat. After looking them over, it seemed like they're intended to fulfill the same purpose for different platforms, and so would remain as parts of the same package.

Ultimately, I based that decision off of reading the following in the net README:

Different platforms gather the data above with different mechanisms. Telegraf uses the (gopsutil) package, which under Linux reads the /proc/net/dev file. Under freebsd/openbsd and darwin the plugin uses netstat.

@sdomino sdomino force-pushed the update/individual-system-inputs branch 3 times, most recently from 090f6a0 to 078533d Compare July 10, 2018 04:41
@sdomino sdomino force-pushed the update/individual-system-inputs branch from 078533d to 9c50a30 Compare July 10, 2018 05:01
@@ -1,4 +1,4 @@
package system
package inputs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave this file in the system package for the time being? Long term I would like to split it out to the required plugins as well as splitting the interface up, but we should do that after moving the files to reduce the size of the conflict window.

@@ -1,4 +1,4 @@
package system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave in system package for now.

@danielnelson danielnelson added this to the 1.8.0 milestone Jul 11, 2018
@danielnelson danielnelson merged commit 7b73b0d into influxdata:master Jul 11, 2018
@sdomino sdomino deleted the update/individual-system-inputs branch July 12, 2018 03:39
@tstackhouse
Copy link

tstackhouse commented Sep 14, 2018

It was mentioned in #4400 that the system package may be removed soon, with this PR, and with 1.8 on the horizon, what would be the equivalent? Assuming the docs will be updated soon?

@danielnelson
Copy link
Contributor

This is mostly a code organization change. From a users point of view the only change is that the README files for the plugins have been moved to a different location. For example, with the disk input:

- /plugins/inputs/system/DISK_README.md
+ /plugins/inputs/disk/README.md

There isn't any effect on the configuration file or on plugin availability, and the system input plugin is not removed, so there should be no action required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants