Treat devices with keys as keyboards #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiliti
reviewed
May 3, 2021
Some keyboards have an absolute axis and would erroneously not be treated as a keyboard. Now any device with keys would have the ID_INPUT_KEY property set.
TAAPArthur
force-pushed
the
multi_media_keys
branch
from
070901f
to
3d188e7
Compare
|
I saw you have some trouble with hotplugging. Feel free to open an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some keyboards have an absolute axis and would erroneously not be treated
as a keyboard. Now any device with keys would have the ID_INPUT_KEY
property set.
So I have a keyboard where the multimedia keys are treated as a separate input device. This device has a volume slider which apparently has an absolute axis. Given the mutual exclusion between devices with axis and keyboards the device was left unlabeled and unrecognized by X. The patch removes said exclusion.
So with this patch it is theoretically possible for a device to have both the keyboard property and some pointer property. Don't know what device that would be, but if it was a concern can just rearrange the if/else statement so that the keyboard check comes first