From 5bf62f210911735d4e207ae24cf5f34f4106b320 Mon Sep 17 00:00:00 2001 From: ftoromanoff Date: Wed, 15 May 2024 16:56:55 +0200 Subject: [PATCH] refactor(3dTiles): supp unused parameter in debug set up --- examples/3dtiles_25d.html | 2 +- examples/3dtiles_basic.html | 4 ++-- examples/3dtiles_batch_table.html | 4 +--- examples/3dtiles_pointcloud.html | 2 +- utils/debug/3dTilesDebug.js | 2 +- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/3dtiles_25d.html b/examples/3dtiles_25d.html index 16fb4cfacd..41cc65ad15 100644 --- a/examples/3dtiles_25d.html +++ b/examples/3dtiles_25d.html @@ -114,7 +114,7 @@ var menu = new GuiTools('menuDiv', view); var d = new debug.Debug(view, menu.gui); debug.createTileDebugUI(menu.gui, view, view.tileLayer, d); - debug.create3dTilesDebugUI(menu.gui, view, $3dTilesLayer, d); + debug.create3dTilesDebugUI(menu.gui, view, $3dTilesLayer); diff --git a/examples/3dtiles_basic.html b/examples/3dtiles_basic.html index 3dff817953..9db050b8a3 100644 --- a/examples/3dtiles_basic.html +++ b/examples/3dtiles_basic.html @@ -81,8 +81,8 @@ // Add the UI Debug var d = new debug.Debug(view, menuGlobe.gui); debug.createTileDebugUI(menuGlobe.gui, view, view.tileLayer, d); - debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerDiscreteLOD, d); - debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerRequestVolume, d); + debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerDiscreteLOD); + debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerRequestVolume); d.zoom = function() { view.camera3D.position.set(1215013.9, -4736315.5, 4081597.5); view.camera3D.quaternion.set(0.9108514448729665, 0.13456816437801225, 0.1107206134840362, 0.3741416847378546); diff --git a/examples/3dtiles_batch_table.html b/examples/3dtiles_batch_table.html index 4e074f8cd3..4471f98eb4 100644 --- a/examples/3dtiles_batch_table.html +++ b/examples/3dtiles_batch_table.html @@ -80,9 +80,7 @@ // Add a debug UI var d = new debug.Debug(view, menuGlobe.gui); debug.createTileDebugUI(menuGlobe.gui, view, view.tileLayer, d); - debug.create3dTilesDebugUI(menuGlobe.gui, view, - $3dTilesLayerBTHierarchy, - d); + debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerBTHierarchy); diff --git a/examples/3dtiles_pointcloud.html b/examples/3dtiles_pointcloud.html index d2ce6c9f91..25300f0727 100644 --- a/examples/3dtiles_pointcloud.html +++ b/examples/3dtiles_pointcloud.html @@ -88,7 +88,7 @@ $3dTilesLayerSetePC.whenReady .then(() => { debug.createTileDebugUI(menuGlobe.gui, view, view.tileLayer, d); - debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerSetePC, d); + debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerSetePC); }); diff --git a/utils/debug/3dTilesDebug.js b/utils/debug/3dTilesDebug.js index 744ab805a2..a6a0e79f8e 100644 --- a/utils/debug/3dTilesDebug.js +++ b/utils/debug/3dTilesDebug.js @@ -7,7 +7,7 @@ import GeometryDebug from './GeometryDebug'; const bboxMesh = new THREE.Mesh(); -export default function create3dTilesDebugUI(datDebugTool, view, _3dTileslayer, debugInstance) { +export default function create3dTilesDebugUI(datDebugTool, view, _3dTileslayer) { const gui = GeometryDebug.createGeometryDebugUI(datDebugTool, view, _3dTileslayer); // add wireframe