Skip to content

Commit

Permalink
refactor(3dTiles): supp unused parameter in debug set up
Browse files Browse the repository at this point in the history
  • Loading branch information
ftoromanoff committed May 24, 2024
1 parent ff0ff3d commit 5bf62f2
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion examples/3dtiles_25d.html
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
var menu = new GuiTools('menuDiv', view);
var d = new debug.Debug(view, menu.gui);
debug.createTileDebugUI(menu.gui, view, view.tileLayer, d);
debug.create3dTilesDebugUI(menu.gui, view, $3dTilesLayer, d);
debug.create3dTilesDebugUI(menu.gui, view, $3dTilesLayer);
</script>
</body>
</html>
4 changes: 2 additions & 2 deletions examples/3dtiles_basic.html
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
// Add the UI Debug
var d = new debug.Debug(view, menuGlobe.gui);
debug.createTileDebugUI(menuGlobe.gui, view, view.tileLayer, d);
debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerDiscreteLOD, d);
debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerRequestVolume, d);
debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerDiscreteLOD);
debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerRequestVolume);
d.zoom = function() {
view.camera3D.position.set(1215013.9, -4736315.5, 4081597.5);
view.camera3D.quaternion.set(0.9108514448729665, 0.13456816437801225, 0.1107206134840362, 0.3741416847378546);
Expand Down
4 changes: 1 addition & 3 deletions examples/3dtiles_batch_table.html
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,7 @@
// Add a debug UI
var d = new debug.Debug(view, menuGlobe.gui);
debug.createTileDebugUI(menuGlobe.gui, view, view.tileLayer, d);
debug.create3dTilesDebugUI(menuGlobe.gui, view,
$3dTilesLayerBTHierarchy,
d);
debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerBTHierarchy);
</script>
</body>
</html>
2 changes: 1 addition & 1 deletion examples/3dtiles_pointcloud.html
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
$3dTilesLayerSetePC.whenReady
.then(() => {
debug.createTileDebugUI(menuGlobe.gui, view, view.tileLayer, d);
debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerSetePC, d);
debug.create3dTilesDebugUI(menuGlobe.gui, view, $3dTilesLayerSetePC);
});
</script>
</body>
Expand Down
2 changes: 1 addition & 1 deletion utils/debug/3dTilesDebug.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import GeometryDebug from './GeometryDebug';

const bboxMesh = new THREE.Mesh();

export default function create3dTilesDebugUI(datDebugTool, view, _3dTileslayer, debugInstance) {
export default function create3dTilesDebugUI(datDebugTool, view, _3dTileslayer) {
const gui = GeometryDebug.createGeometryDebugUI(datDebugTool, view, _3dTileslayer);

// add wireframe
Expand Down

0 comments on commit 5bf62f2

Please sign in to comment.