Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

使用客户端高级配置bSyncToSystemProperties没有生效 #22

Closed
wuqqq opened this issue Sep 20, 2016 · 5 comments
Closed

使用客户端高级配置bSyncToSystemProperties没有生效 #22

wuqqq opened this issue Sep 20, 2016 · 5 comments

Comments

@wuqqq
Copy link

wuqqq commented Sep 20, 2016

试了一下客户端高级配置:bSyncToSystemProperties,发现源码中对于这个属性是这样解析的:
if (!StringUtils.isEmpty(bSyncToSystemProperties)) { bSyncToSystemProperties = helper.replacePlaceholders(bSyncToSystemProperties, properties); xDiamondConfig.setbSyncToSystemProperties(Boolean.getBoolean(bSyncToSystemProperties)); }
在spring中这样配置:
<bean id="xDiamondConfig" class="io.github.xdiamond.client.spring.XDiamondConfigFactoryBean"> ... <property name="bSyncToSystemProperties" value="true" /> </bean>
这样写属性注入失败(实际并没有拿到true,而是null),Boolean.getBoolean(name)方法是从环境变量中获取value,而实际是直接注入了值"true",这里似乎应该改为Boolean.valueOf(),是我使用有误还是?
不过还是要说,xdiamond很好很强大 :)

@hengyunabc
Copy link
Owner

😂 的确这里搞错了。下次发布修复。

@Xiaobaxi
Copy link

@wuqqq 提交一个pull request也不错啊

@Xiaobaxi
Copy link

@hengyunabc 我们在使用xdiamond,并且也做了一些改造,看看到时候能否提些pull给你。@wuqqq

@hengyunabc
Copy link
Owner

@Xiaobaxi 可以的,非常欢迎提交 pull request.

@zengan
Copy link

zengan commented Oct 8, 2016

xDiamondConfig.setbPrintConfigWhenBoot(Boolean.getBoolean(bPrintConfigWhenBoot));
这个API使用错误,设置为true也是返回false

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants