Upgrade to Rails 4

[aaronlerch]

I've got a branch where I did an upgrade of the app to Rails 4. I don't know that you want to merge it into master directly, but if you create a branch for rails 4 I'd be happy to issue a pull request into that branch.

Or if you prefer to update the app to rails 4 by default (probably reasonably safe) then I'm happy to do a pull request directly to master.

Or of course you can access my repo and merge it in yourself any way you like. :)
Thanks!

[aaronlerch]

Oops, here's my repo: https://github.com/aaronlerch/prelaunchr/tree/rails_4

[danielschwartz]

Sorry about the delay in getting back to you. Will take a look over the next week or so and figure out what the implications would be. I'm all for upgrading to Rails 4, just don't want to leave a bunch of people in the dust. Might make sense to do a final tag with Rails 3 and then have master be Rails 4.

[aaronlerch]

😎 no worries!

[aaronlerch]

It's been about 3 weeks so I figured I'd circle back around and see how you want to handle this? Thanks!

[danielschwartz]

@aaronlerch since there are no tests, and since we will still have to support this project, but rails 4 is a useful addition lets do this: let's merge your changes into a branch that is not master called rails_4. If you could create two PR's, one that merges your changes into a branch called rails_4 on our repo, and one to update the README on our master letting people know there is a Rails 4 version at that branch would be great.

[aaronlerch]

Sounds like a plan!

[phamdt]

i submitted a PR with some tests in case that helps with this one

[ckhatton]

Hi @danielschwartz
I know you are busy, but can someone commit these pull requests, and also start committing the other pull requests, they are starting to pile up. I would like the fork the project, and especially use the Rails4 branch. Please add me as a contributor if you do not have the time. Thanks

[danielschwartz]

@ckhatton we've unfortunately abandoned supporting this project. We'd be happy for you to fork it to a separate repo and become the owner of it, as long as you remove our assets from it.

We just don't have time to support this specific project in addition to all our other open source endeavors. Sorry!

[ckhatton]

@danielschwartz Okay that is fine - I will fork it and see if I can take on the pull requests (which I have never done and not sure is possible to a forked repo) 🎱

[wardpenney]

I've done it over at https://github.com/wardpenney/prelaunchr

I need to remove the assets, but it is Rails 4.2, Ruby 2.2.0

[ckhatton]

@wardpenney Noice! 👍

Are you able to also add the outstanding pull requests?

[irubnich]

Done