Live: enable per-detector analysis flags #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titodalcanton
force-pushed
the
live_ifo_specific_analyze_flags
branch
from
e03f34f
to
efb015b
Compare
titodalcanton
changed the title
|
@ahnitz I still need to test this more carefully, but the approach is finalized, so ready for your review. |
titodalcanton
force-pushed
the
live_ifo_specific_analyze_flags
branch
from
34ebcc3
to
43d4c88
Compare
|
This is now tested with fake frame files carrying various combinations of states and DQ vetoes. @ahnitz ready for your review. |
ahnitz
reviewed
Apr 20, 2019
ahnitz
approved these changes
Apr 20, 2019
|
@titodalcanton One minor question, otherwise, this seems fine. |
titodalcanton
force-pushed
the
live_ifo_specific_analyze_flags
branch
from
815f660
to
38e5c69
Compare
JulianWesterweck
pushed a commit
to JulianWesterweck/pycbc
that referenced
this pull request
Jun 7, 2019
* A bit of refactoring, and enable per-detector analysis flags * Add new LIGO DQ flag * Enable usage of inverted Virgo-style DQ channel * Typo * Typo and codeclimate * Typo * Only use DQ vector when available * Remove unused arg * Avoid dangerous variable reuse * Fix errors * Move StrainBuffer init to class method
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* A bit of refactoring, and enable per-detector analysis flags * Add new LIGO DQ flag * Enable usage of inverted Virgo-style DQ channel * Typo * Typo and codeclimate * Typo * Only use DQ vector when available * Remove unused arg * Avoid dangerous variable reuse * Fix errors * Move StrainBuffer init to class method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do some refactoring of the data reader code in
pycbc_live, and add the ability to use different analysis flags for different detectors. This is necessary for Virgo in O3.This patch also fixes a couple bugs in the followup code that cause exceptions when one of the detectors is not observing.
Note that this patch will require a change in the current PyCBC Live configuration.
Needs testing.