Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gradio dev tools a local dependency rather than bundling #8066

Merged
merged 21 commits into from
Apr 19, 2024
Merged

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Apr 18, 2024

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes #6087

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Apr 18, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website failed! Details
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/54635b14648ffd559c9344d64a1f22eb3eb7a703/gradio-4.27.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@54635b14648ffd559c9344d64a1f22eb3eb7a703#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Apr 18, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/accordion patch
@gradio/annotatedimage patch
@gradio/audio patch
@gradio/button patch
@gradio/chatbot patch
@gradio/checkbox patch
@gradio/checkboxgroup patch
@gradio/client patch
@gradio/code patch
@gradio/colorpicker patch
@gradio/column patch
@gradio/dataframe patch
@gradio/dataset patch
@gradio/downloadbutton patch
@gradio/dropdown patch
@gradio/fallback patch
@gradio/file patch
@gradio/fileexplorer patch
@gradio/form patch
@gradio/gallery patch
@gradio/group patch
@gradio/highlightedtext patch
@gradio/html patch
@gradio/image patch
@gradio/imageeditor patch
@gradio/json patch
@gradio/label patch
@gradio/markdown patch
@gradio/model3d patch
@gradio/multimodaltextbox patch
@gradio/number patch
@gradio/paramviewer patch
@gradio/plot patch
@gradio/preview patch
@gradio/radio patch
@gradio/row patch
@gradio/simpledropdown patch
@gradio/simpleimage patch
@gradio/simpletextbox patch
@gradio/slider patch
@gradio/statustracker patch
@gradio/tabitem patch
@gradio/tabs patch
@gradio/textbox patch
@gradio/uploadbutton patch
@gradio/video patch
gradio patch
gradio_test patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

make gradio dev tools a local dependency rather than bundling

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR works really well @pngwn !

I was able to import SmilesDrawer and both dev/build versions work.

Left some small comments but this can be merged as soon as they are resolved. We also need to add @gradio/preview to each component right?

gradio/cli/commands/components/dev.py Outdated Show resolved Hide resolved
gradio/cli/commands/components/dev.py Show resolved Hide resolved
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works very nicely @pngwn !

@pngwn pngwn merged commit 624f9b9 into main Apr 19, 2024
8 checks passed
@pngwn pngwn deleted the 6078-cc-dev branch April 19, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Component break on JS Import for some libraries
3 participants