-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove Python 2 support #657
Conversation
@andrewsg The |
@tseaver This was on hold due to the release freeze last month. Thank you as always for your thorough review. PTAL. Will address google3 issue shortly. |
So happy to see all the clean up. Nothing else to add beyond the requests that tres and cathy made; lgtm. Is there a change that should be made in here for kokoro to not try and still run the system-2.7 tests? |
Co-authored-by: cojenco <cathyo@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🎉🎉 Thanks Andrew for getting us across the finish line!
BREAKING CHANGE: This PR removes Python 2 support in the setup.py metadata, test runner and code itself. This is intended to be released as a major version update. Python 2 users can continue to use the 1.x version of the client library.