-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove threads in transfer manager samples #1029
Conversation
fyi: |
# many threads can slow operations, especially with large files, due to | ||
# contention over the Python GIL. | ||
# threads=4 | ||
# The maximum number of worker processes that should be used to handle the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this sample doesn't mention the worker type constants, let's try omitting them.
"The maximum number of processes to use for the operation. The performance impact of this value depends on the use case, but smaller files usually benefit from a higher number of processes. Each additional process occupies some CPU and memory resources until finished."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitted worker type in comments related to processes. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@dandhlee Thanks Dan. Since the samples are public-facing I think they could stand to be in the release notes. I'll merge with docs: for now and if the release notes look messy I'll edit them at launch. |
Fixes #1028 🦕