Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add role field for namespace api #299

Merged
merged 4 commits into from
Feb 9, 2024
Merged

✨ Add role field for namespace api #299

merged 4 commits into from
Feb 9, 2024

Conversation

tosone
Copy link
Contributor

@tosone tosone commented Feb 9, 2024

No description provided.

@tosone tosone added the enhancement New feature or request label Feb 9, 2024
@tosone tosone added this to the Release v1.2.0 milestone Feb 9, 2024
@tosone tosone self-assigned this Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (be5fde3) 21.37% compared to head (2a08a06) 20.75%.

Files Patch % Lines
pkg/auth/mocks/service.go 20.58% 27 Missing ⚠️
pkg/auth/namespace.go 0.00% 26 Missing ⚠️
pkg/dal/dao/mocks/setting.go 0.00% 12 Missing ⚠️
pkg/dal/dao/mocks/namespace_member.go 0.00% 9 Missing ⚠️
pkg/dal/dao/namespace_member.go 0.00% 8 Missing ⚠️
pkg/handlers/namespaces/namespaces_list.go 55.55% 3 Missing and 1 partial ⚠️
pkg/auth/artifact.go 0.00% 3 Missing ⚠️
pkg/auth/repository.go 0.00% 3 Missing ⚠️
pkg/auth/tag.go 0.00% 3 Missing ⚠️
pkg/handlers/namespaces/namespaces_get.go 57.14% 2 Missing and 1 partial ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   21.37%   20.75%   -0.63%     
==========================================
  Files         287      285       -2     
  Lines       18790    18515     -275     
==========================================
- Hits         4017     3842     -175     
+ Misses      14366    14297      -69     
+ Partials      407      376      -31     
Flag Coverage Δ
unit-test-mysql 20.75% <20.42%> (-0.63%) ⬇️
unit-test-postgresql 20.75% <20.42%> (-0.63%) ⬇️
unit-test-sqlite3 20.75% <20.42%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tosone tosone added this pull request to the merge queue Feb 9, 2024
Merged via the queue into go-sigma:main with commit 1fa4acc Feb 9, 2024
11 checks passed
@tosone tosone deleted the dev branch February 9, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant