Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a default timeout #18

Open
nivekuil opened this issue Sep 19, 2020 · 2 comments
Open

Consider adding a default timeout #18

nivekuil opened this issue Sep 19, 2020 · 2 comments

Comments

@nivekuil
Copy link

I think it's pretty much always a good idea to have a default timeout on I/O; it prevents some catastrophic behavior in production that there's really no good reason to allow. Most libraries do this, like the Apache client which clj-http wraps, which defaults to the system timeout: https://stackoverflow.com/questions/9734384/default-timeout-for-httpcomponent-client

Apparently the new Java API which this wraps doesn't set a default timeout, which I think is unfortunate. Would you consider adding one to this library?

@gnarroway
Copy link
Owner

Hi! Thanks for your interest.

The request doesn’t sound unreasonable. Would you like to open a PR for it? I’ll leave this issue open for the time being in case there are any immediate objections by anyone.

@gnarroway
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants