Scripts fixes to prevent teachers from continuously needing to input their PAT #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
. |
ppremk
approved these changes
Jul 13, 2022
|
merging on behalf @rajbos |
parkerbxyz
reviewed
Jul 13, 2022
| @@ -269,8 +269,8 @@ create_issue() { | |||
|
|
|||
| echo -n "Creating issue: $title... " | |||
|
|
|||
| # Wait for 1 second to avoid secondary rate limiting | |||
| sleep 1 | |||
| # Wait for 2 second to avoid secondary rate limiting, 1 second was nog enough | |||
There was a problem hiding this comment.
Suggested change
| # Wait for 2 second to avoid secondary rate limiting, 1 second was nog enough | |
| # Wait for 2 second to avoid secondary rate limiting (1 second was not enough) |
| @@ -294,8 +294,8 @@ create_pull_request() { | |||
|
|
|||
| echo -n "Creating pull request: $title... " | |||
|
|
|||
| # Wait for 1 second to avoid secondary rate limiting | |||
| sleep 1 | |||
| # Wait for 2 seconds to avoid secondary rate limiting, 1 second was nog enough | |||
There was a problem hiding this comment.
Suggested change
| # Wait for 2 seconds to avoid secondary rate limiting, 1 second was nog enough | |
| # Wait for 2 seconds to avoid secondary rate limiting (1 second was not enough) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with script 2, 4 and 6
There is also an extra test for the OSTYPE in here, so that the check works on Windows with WSL as well