-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate our mingw-w64-git into MSYS2 proper #284
Comments
It would be great to be able to install msys2 and have also avaiable the latest version of git for windows! Thanks for the effort. |
I am glad we are in agreement! This is exactly what this ticket is about. |
@fabio-porcedda This is already possible if you want. I'm doing this since a few months without problems. I added instructions on the wiki: https://github.com/git-for-windows/git/wiki/Install-inside-MSYS2-proper |
@maoueh the steps described there are roughly the same steps the Git for Windows SDK is doing. In fact. the Git for Windows SDK is roughly just that: MSYS2 with a special repository before the core repositories. |
I'm not sure I understand the meaning of your comment. Was it just informational? |
Sure. |
So here are the Pull Requests I opened so far:
Once those are in, I need to open another Pull Request to update the |
Alexpux/Cygwin#3 was closed because the patch had made it into Cygwin proper in the meantime. The other |
This is very interesting. I have been waiting for an easy way to get Git inside MSYS / MinGW Shell for a long time, and now it seems to be very close to happening for MSYS2 - great! What is the status of this work? It seems also Alexpux/Cygwin#4 was closed because the patch has made it into Cygwin proper, but the other pull requests are hanging. Thx a lot for your work! |
The main problem now is that the following Pull Requests need more or less work (I might have forgotten other things):
That last one needs most of the work: we have some patches for the POSIX <-> Windows path mangling that are required to pass Git's test suite (without which pass I will never even consider releasing a Git package). One of those patches, however, breaks MSYS2's expectations, and I have to rework that patch. |
This is pretty cool. And after installing in my msys2 I have found no issues so far. |
@Swoorup then you did not run Git's regression test suite... 😉 |
i use quite a few git commands, rebase, status, commit, pull, revert, amend, merge. I am not really familiar about the git internals. |
@Swoorup you can do what you want, of course. The issues are subtle at best, anyway. |
Unfortunately, it has become clear that it would cost too much time and effort to get Git for Windows' patches into MSYS2. On a happy note: this frees up a lot of time to work on making Git for Windows better! 😃 |
Perhaps update the wiki to mention this won't be happening? Currently it says this is planned. |
@mehrdadn where does it say that? Could you update that, too? |
@mehrdadn thanks! |
Working for me!!! |
Hi! Now that both Cygwin version and Bash version are in sync with MSYS2 upstream (i.e. with the release of Git for Windows 2.37.2), would it be worth revisiting this? I'm aware that https://github.com/git-for-windows/git/wiki/Install-inside-MSYS2-proper exists, and I'm more than happy to use it, but it would be very convenient to have a fresh installation of MSYS2 and run just |
@rashil2000 @maehne @BasixKOR @pabranch @int-index @gphg I would like to encourage you to think long and hard about any way you could help bring this about. It is a huge task you are asking for. |
@dscho: Could you give a summary, what tasks are open to make this happen? As this issue was created 7 years ago, I imagine some things have moved over this time. I still would like to see this, as I regularly use software packaged in MSYS2. I appreciate the frequent updates to Git for Windows (which I manage with Unfortunately, I cannot commit any resources to this issue, as I am already involved in several other projects leaving me no bandwidth. The only thing, I can offer, is testing. |
Most of the adjustments needed to run Git smoothly are in the fork of msys2-runtime as well as in the post-install script of the
That convenience would come at the cost of an increased maintenance burden, and there are plenty of users who seem very comfortable to bow completely out of paying that cost.
The problem is that everyone agrees with this stance, myself included: I cannot commit any resources to this issue. Some people find it reasonable to ask others to commit resources to this issue while they're unwilling/unable to do the same, but I am not in that group of people. I even wonder why bother asking for what needs to be done, when that request is followed immediately by the statement that the requester won't do any of it. What outcome is expected other than to cause frustration all around? |
This ticket entails several tasks.
The biggest one is to get our msys2-runtime patches integrated into upstream (maybe not as-are, but with modifications).
We also need to make sure that our
mintty
changes are integrated into MSys2, either as-are (into MSYS2-packages), or even better as a new mintty release once mintty/mintty#471 is merged.The remaining task is to rename our MINGW-packages'
master
branch and restart a newmaster
from upstream, just integrating the diff to ourmingw-w64-git
.The text was updated successfully, but these errors were encountered: