From 8498e0dbcc1a202266f9b50eaeac99b48fc83402 Mon Sep 17 00:00:00 2001 From: Atsushi Eno Date: Mon, 2 Jun 2014 17:48:00 +0900 Subject: [PATCH] [MS.Build] ProjectOnErrorInstance should not cause build failure. --- .../Microsoft.Build/Microsoft.Build.Internal/BuildEngine4.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mcs/class/Microsoft.Build/Microsoft.Build.Internal/BuildEngine4.cs b/mcs/class/Microsoft.Build/Microsoft.Build.Internal/BuildEngine4.cs index 3bdb9bb6f928..1f501683ce27 100644 --- a/mcs/class/Microsoft.Build/Microsoft.Build.Internal/BuildEngine4.cs +++ b/mcs/class/Microsoft.Build/Microsoft.Build.Internal/BuildEngine4.cs @@ -285,6 +285,10 @@ bool DoBuildTarget (ProjectTargetInstance target, TargetResult targetResult, Int continue; } + var onError = child as ProjectOnErrorInstance; + if (onError != null) + continue; // evaluated under catch clause. + throw new NotSupportedException (string.Format ("Unexpected Target element children \"{0}\"", child.GetType ())); } } catch (Exception ex) {