Refactor Bbox, Remove Public/Private Stac Collection, and Fix 2.11 builds #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2019 15:26
This was based on a misreading of the spec, turns out that the proprietary license does not require a license link and links _SHOULD_ only include one, not must.
jisantuc
suggested changes
Nov 12, 2019
There was a problem hiding this comment.
I think the bbox gens needs some sanitization -- running into a lot of
[info] - items should round trip *** FAILED ***
[info] ExtentRangeError was thrown during property evaluation.
[info] Message: Invalid Extent: ymin must be less than ymax (ymin=1.6305147092067003E-259, ymax=-1.3165357861436286E104)
[info] Occurred when passed generated values (
[info]
[info] )
errors in tests
Otherwise good to go 👌
|
Oh oops, I didn't run tests after adding the extent part -- I'll fix that up. |
The Extent constructor throws an exception, in order to handle that `toExtent` returns an `Either[Throwable, Extent]` now
notthatbreezy
force-pushed
the
feature/cmb/refactor-bbox
branch
from
2dc072b
to
f67a17c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This refactors Bbox to be a sealed trait, re-enables both 2d and 3d bounding boxes in tests, fixes the 2.11 builds, and also removes the distinction between public/private collections since that original split was based on my misreading of the specification.
Checklist
Testing Instructions
Closes #177