Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly export ros_gz_bridge for downstream targets #503

Merged
merged 3 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add a virtual destructor to suppress compiler warning
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
  • Loading branch information
mjcarroll committed Feb 22, 2024
commit 3f364d6fe71e63805b44bc14bc3cf07954736043
1 change: 1 addition & 0 deletions ros_gz_bridge/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ add_library(${bridge_lib}
src/bridge_handle_ros_to_gz.cpp
src/bridge_handle_gz_to_ros.cpp
src/factory_interface.cpp
src/service_factory_interface.cpp
src/service_factories/ros_gz_interfaces.cpp
src/ros_gz_bridge.cpp
${convert_files}
Expand Down
24 changes: 24 additions & 0 deletions ros_gz_bridge/src/service_factory_interface.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Copyright 2024 Open Source Robotics Foundation, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#include "service_factory_interface.hpp"

namespace ros_gz_bridge
{

ServiceFactoryInterface::~ServiceFactoryInterface()
{
}

} // namespace ros_gz_bridge
2 changes: 2 additions & 0 deletions ros_gz_bridge/src/service_factory_interface.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ namespace ros_gz_bridge
class ServiceFactoryInterface
{
public:
virtual ~ServiceFactoryInterface() = 0;

virtual
rclcpp::ServiceBase::SharedPtr
create_ros_service(
Expand Down
Loading