Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rolling] Port test improvements from #272 #273

Merged
merged 3 commits into from
Jul 8, 2022
Merged

[rolling] Port test improvements from #272 #273

merged 3 commits into from
Jul 8, 2022

Conversation

mjcarroll
Copy link
Collaborator

@mjcarroll mjcarroll commented Jul 8, 2022 •
edited
Loading

🦟 Bug fix

Summary

Port test improvements from #272 on galactic to humble+.

This should clear up some of the CI issues that we have been facing.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
[rolling] Port test improvements from #272
34bb2e0 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from chapulina as a code owner July 8, 2022 14:49
@mjcarroll
Copy link
Collaborator Author

garden CI is failing to find ignition-math7. @chapulina has this ever worked? Is it expected to work or can we disable it until those packages are ready?

@mjcarroll
Copy link
Collaborator Author

CC: @quarkytale this should get you closer to green.

@chapulina chapulina added the ROS 2 ROS 2 label Jul 8, 2022
ahcorde
ahcorde approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

chapulina and others added 2 commits July 8, 2022 10:58
@mjcarroll mjcarroll merged commit d94e7c7 into ros2 Jul 8, 2022
@mjcarroll mjcarroll deleted the port_272 branch July 8, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
ROS 2 ROS 2
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @ahcorde @chapulina