Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to create PR against ROS gz_*_vendor repositories in release.py #1151

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ced8c08
WIP: methods to run gh create issue
j-rivero May 30, 2024
b68bd35
Fully working version
j-rivero May 31, 2024
db11527
Missing helper file
j-rivero May 31, 2024
67f4a2b
Improve the error reporting on gh
j-rivero May 31, 2024
3236d73
Implement a basic testing
j-rivero May 31, 2024
8ed2830
Cleanup
j-rivero Jun 3, 2024
fda1471
Merge branch 'master' into jrivero/vendor_gh_issue
j-rivero Jun 3, 2024
0087404
WIP: create PR for vendor_repositories
j-rivero Jun 7, 2024
a777cd6
Implement the PR creation
j-rivero Jun 11, 2024
6132758
Merge remote-tracking branch 'origin' into jrivero/vendor_gh_pr
j-rivero Jun 11, 2024
6610c74
Remove debug
j-rivero Jun 11, 2024
641899b
Dealing with error code coming from get_collections_from_package_and_…
j-rivero Jun 11, 2024
80475de
Implement venv creation for vendor
j-rivero Jul 19, 2024
8234443
Implement then --only-bump-ros-vendor-package option
j-rivero Jul 19, 2024
ed6ace7
Merge remote-tracking branch 'origin/master' into jrivero/vendor_gh_pr
azeey Sep 26, 2024
f049c45
Add ionic->rolling, harmonic->jazzy
azeey Sep 26, 2024
807070d
Ignore dry-run when updating vendor package. Otherwise, the dry-run w…
azeey Sep 26, 2024
1a84b58
Do not need to make argparse explicit
j-rivero Sep 26, 2024
c2da471
Update all files after running the create_vendor_package script
j-rivero Sep 26, 2024
6c1e3c0
Fix test suite by injecting testing data
j-rivero Sep 26, 2024
4180170
Use ssh protocol when cloning
j-rivero Sep 27, 2024
24d6a83
Avoid to release metapackages
j-rivero Sep 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
  • Loading branch information
j-rivero committed Jun 3, 2024
commit 8ed28301c45bcc1016946d77de85f3df7988b790
3 changes: 2 additions & 1 deletion release.py
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,8 @@ def get_vendor_github_repo(package_name):

def create_issue_in_repo(github_repo, title, body):
_out = b""
# For parsing the \n correctly we need to store the content in a temp
# file and pass it as --body-file
with NamedTemporaryFile("w", delete=True) as f:
f.write(body)
f.flush()
Expand All @@ -558,7 +560,6 @@ def create_issue_in_repo(github_repo, title, body):

def create_issue_in_gz_vendor_repo(args, ros_distro):
gz_vendor_repo = get_vendor_github_repo(args.package)
gz_vendor_repo = 'j-rivero/test'
title = f'Update version for {ros_distro} to the latest tag of {args.package}: {args.version}'
body = f'The {get_canonical_package_name(args.package)} repository tagged a new: {args.version} '\
'This repository needs to be updated accordingly for the branch {ros_distro}:\n'\
Expand Down
Loading